From: SourceForge.net <no...@so...> - 2008-12-21 04:03:44
|
Bugs item #2455436, was opened at 2008-12-21 05:03 Message generated for change (Tracker Item Submitted) made by Item Submitter You can respond by visiting: https://sourceforge.net/tracker/?func=detail&atid=684730&aid=2455436&group_id=119701 Please note that this message will contain a full copy of the comment thread, including the initial issue submission, for this request, not just the latest update. Category: Platform Interface Group: v4.0 Status: Open Resolution: None Priority: 5 Private: No Submitted By: jfaucher (jfaucher) Assigned to: Nobody/Anonymous (nobody) Summary: Windows/SystemCommands.cpp: 'CD "path" not supported Initial Comment: On Windows, when the 'CD' command is directly handled by the ooRexx process, a path surrounded by quotes is not supported : 'cd "c:\my directory"' does not work, whereas 'cd c:\my directory' works... This kind of quoted path is automatically inserted by Windows when you drag&drop a directory (whose path contains spaces) from the file explorer to the ooRexx command window. I propose a patch to support a quoted path : In SystemCommands.cpp, before calling _chdir, remove all the quotes from the path. This patch fixes also an error in systemCommandHandler : the instruction inQuotes = inQuotes should be probably inQuotes = !inQuotes ---------------------------------------------------------------------- You can respond by visiting: https://sourceforge.net/tracker/?func=detail&atid=684730&aid=2455436&group_id=119701 |
From: SourceForge.net <no...@so...> - 2008-12-21 07:03:52
|
Bugs item #2455436, was opened at 2008-12-20 20:03 Message generated for change (Comment added) made by miesfeld You can respond by visiting: https://sourceforge.net/tracker/?func=detail&atid=684730&aid=2455436&group_id=119701 Please note that this message will contain a full copy of the comment thread, including the initial issue submission, for this request, not just the latest update. Category: Platform Interface Group: v4.0 >Status: Pending >Resolution: Fixed Priority: 5 Private: No Submitted By: jfaucher (jfaucher) >Assigned to: Mark Miesfeld (miesfeld) Summary: Windows/SystemCommands.cpp: 'CD "path" not supported Initial Comment: On Windows, when the 'CD' command is directly handled by the ooRexx process, a path surrounded by quotes is not supported : 'cd "c:\my directory"' does not work, whereas 'cd c:\my directory' works... This kind of quoted path is automatically inserted by Windows when you drag&drop a directory (whose path contains spaces) from the file explorer to the ooRexx command window. I propose a patch to support a quoted path : In SystemCommands.cpp, before calling _chdir, remove all the quotes from the path. This patch fixes also an error in systemCommandHandler : the instruction inQuotes = inQuotes should be probably inQuotes = !inQuotes ---------------------------------------------------------------------- >Comment By: Mark Miesfeld (miesfeld) Date: 2008-12-20 23:03 Message: Committed revision 3798. The: inQuotes = inQuotes should be probably inQuotes = !inQuotes was a good catch. It happened during some of the code cleanup since 3.2.0. I was surprised that something like: 'cd "\Program Files"' did not work. It didn't work in 3.2.0 either. The quotes definitely need to be removed for _chdir, or even the Windows API SetCurrentDirectory(), to work. Thanks a lot, we could use more help. By the way, please don't use tabs in your patches. ;-) The current code base does not have tabs. ---------------------------------------------------------------------- You can respond by visiting: https://sourceforge.net/tracker/?func=detail&atid=684730&aid=2455436&group_id=119701 |
From: SourceForge.net <no...@so...> - 2010-02-19 18:18:38
|
Bugs item #2455436, was opened at 2008-12-20 20:03 Message generated for change (Comment added) made by miesfeld You can respond by visiting: https://sourceforge.net/tracker/?func=detail&atid=684730&aid=2455436&group_id=119701 Please note that this message will contain a full copy of the comment thread, including the initial issue submission, for this request, not just the latest update. Category: Platform Interface Group: v4.0 >Status: Closed Resolution: Fixed Priority: 5 Private: No Submitted By: jfaucher (jfaucher) Assigned to: Mark Miesfeld (miesfeld) Summary: Windows/SystemCommands.cpp: 'CD "path" not supported Initial Comment: On Windows, when the 'CD' command is directly handled by the ooRexx process, a path surrounded by quotes is not supported : 'cd "c:\my directory"' does not work, whereas 'cd c:\my directory' works... This kind of quoted path is automatically inserted by Windows when you drag&drop a directory (whose path contains spaces) from the file explorer to the ooRexx command window. I propose a patch to support a quoted path : In SystemCommands.cpp, before calling _chdir, remove all the quotes from the path. This patch fixes also an error in systemCommandHandler : the instruction inQuotes = inQuotes should be probably inQuotes = !inQuotes ---------------------------------------------------------------------- Comment By: Mark Miesfeld (miesfeld) Date: 2010-02-19 10:18 Message: The fix for this item was in the 4.0.0 release. ---------------------------------------------------------------------- Comment By: Mark Miesfeld (miesfeld) Date: 2008-12-20 23:03 Message: Committed revision 3798. The: inQuotes = inQuotes should be probably inQuotes = !inQuotes was a good catch. It happened during some of the code cleanup since 3.2.0. I was surprised that something like: 'cd "\Program Files"' did not work. It didn't work in 3.2.0 either. The quotes definitely need to be removed for _chdir, or even the Windows API SetCurrentDirectory(), to work. Thanks a lot, we could use more help. By the way, please don't use tabs in your patches. ;-) The current code base does not have tabs. ---------------------------------------------------------------------- You can respond by visiting: https://sourceforge.net/tracker/?func=detail&atid=684730&aid=2455436&group_id=119701 |