#689 Add SVN revision number to rexx -v

[Erich]

It would be nice if the output for rexx -v could also include the number of the SVN revision at which the build was done

[Rick McGuire]

I'm not really sure it's a good idea tying things to SVN. There has already been talk around moving things to Git, which might required a different approach. There are already problems building from a Git mirror because the build tries to get the SVN revision number. Those issues need to be sorted out.,

[Rony G. Flatscher]

What about if having something like a "svn"-prefix to the svn revision number, such that the revision number clearly refers to svn (and should there be a move to git change then having a "git"-prefix instead)?

[Erich]

I had been thinking of just changing the rexx - v output to something
like below.
This should be just for info, nothing that should be relied on, or being
parsed off.
The SVN version info is often inaccurate, as 1) it may be missing
altogether because our current CMake tests for if(SUBVERSION_FOUND *AND IS_DIRECTORY ".svn"*) which typically fails for out-of-source builds and
2) the SVN revision number seems to be only updated if CMake is run, not
if you just run nmake to do an incremental build

Open Object Rexx Version 5.0.0 r11233
Build date: May  2 2017
Addressing mode: 64

I haven't yet seen a GIT revision number
I also don't know whether or how our GIT shadow's revision numbers stay in
sync with SVN
We cannot even commit from GIT today, can we? Isn't GIT just a read-only
shadow for us?

On Tue, May 2, 2017 at 8:21 PM, Rony G. Flatscher orexx@users.sf.net
wrote:

What about if having something like a "svn"-prefix to the svn revision
number, such that the revision number clearly refers to svn (and should
there be a move to git change then having a "git"-prefix instead)?

---

[feature-requests:#689] Add SVN revision number to rexx -v

Status: accepted
Milestone: 5.0.0
Created: Tue May 02, 2017 05:50 PM UTC by Erich
Last Updated: Tue May 02, 2017 05:54 PM UTC
Owner: Erich

It would be nice if the output for rexx -v could also include the number
of the SVN revision at which the build was done

---

Sent from sourceforge.net because you indicated interest in <
https://sourceforge.net/p/oorexx/feature-requests/689/>

To unsubscribe from further messages, please visit <
https://sourceforge.net/auth/subscriptions/>

[Gil Barmwater]

I think I'd rather see it added as an attribute of the .RexxInfo object. Perhaps a "neutral" name along the lines of Revision Control Number would work for either SVN or GIT. And we should attempt to make sure it is accurate at least for all Release or Beta builds but we probably can't for user builds if it is a procedural thing.

FWIW...

[Rick McGuire]

Erich, are you still working on this? It appears it is possible to get this information at build time, but it requires generating an include file as part of the build.

https://stackoverflow.com/questions/3780667/use-cmake-to-get-build-time-subversion-revision

This is largely a cut-and-paste job except we'll need to generate some sort of dummy header file if this is not an svn checkout.

[Erich]

I'll do this.
I'm not sure though, we should use the linked build-time SVN retrieval code.
Creating an svnversion.h through a separate cmake is fine, but we also use the SVN revision as a part of the name of the NSIS installer and the Unix packages, which is done in the main cmake.

The cmake configuration which is necessary to update the SVN revision through the main cmake, can be made to run by simply touching CMakeLists.txt before running nmake (or make on Unix).
Is this acceptable?

[Rick McGuire]

I suspect it will be acceptable. I've been playing around with this, and
I'm able to get a file generated, but It's a real pain to work with and it
doesn't seem to update always.

Rick

On Fri, Dec 21, 2018 at 5:27 PM Erich erich_st@users.sourceforge.net
wrote:

I'll do this.
I'm not sure though, we should use the linked build-time SVN retrieval
code.
Creating an svnversion.h through a separate cmake is fine, but we also use
the SVN revision as a part of the name of the NSIS installer and the Unix
packages, which is done in the main cmake.

The cmake configuration which is necessary to update the SVN revision
through the main cmake, can be made to run by simply touching
CMakeLists.txt before running nmake (or make on Unix).
Is this acceptable?

---

[feature-requests:#689] Add SVN revision number to rexx -v

Status: accepted
Milestone: 5.0.0
Created: Tue May 02, 2017 05:50 PM UTC by Erich
Last Updated: Fri Dec 21, 2018 01:58 PM UTC
Owner: Erich

It would be nice if the output for rexx -v could also include the number
of the SVN revision at which the build was done

---

Sent from sourceforge.net because you indicated interest in <
https://sourceforge.net/p/oorexx/feature-requests/689/>

To unsubscribe from further messages, please visit <
https://sourceforge.net/auth/subscriptions/>

[Erich]

Committed revision [r11637]
Adds SVN revision number to rexx -v and rexxc version output
Renames existing RexxInfo method revision() to modification()
Adds RexxInfo method revision()
Updates to rexxref

[Gil Barmwater]

Looks like we need an update to the PG as well; sect. 2.2 has an example of the output of rexx -v which doesn't show the (new) SVN revision.

[Erich]

Looks like we need an update to the PG as well

Gil, done. Thanks for pointing out.