Menu

#1766 rexximage cleanup: removeClassMethod forgets some classes

5.0.0
closed
Erich
None
none
1
2023-01-01
2021-05-19
jfaucher
No

ooRexx5, MacOs
After image building, the methods DEFINECLASSMETHOD and INHERITINSTANCEMETHODS
are still available on these classes (listed by rexximageCheck.rex):
CircularQueue
DescendingComparator
OrderedCollection
Properties
Stream
StreamSupplier
They are supposed to be removed from all the classes.

Code review:
Typo in removeClassMethod: i < subclass_list->size(), must be i <= ...

Not related to the methods not removed, but I think this change should also be applied:
Everywhere getSubClasses() is called, the end test for iteration should compare
with items(), not with size()
because weakReferenceArray allocates an array that can be larger than needed.
The get(i) with i > items() will return a NULL value, right ?

The attached patch ClassClass.diff fixes the typo and replace size() by items().

2 Attachments

Discussion

  • Erich

    Erich - 2021-05-20
    • status: open --> pending
    • assigned_to: Erich
     
  • Erich

    Erich - 2021-05-20

    Fixed code with revision [r12250]
    Jean-Louis, thanks for noting the issue and for providing a patch!

     

    Related

    Commit: [r12250]

  • Rony G. Flatscher

    • Status: pending --> closed
     

Anonymous
Anonymous

Add attachments
Cancel





MongoDB Logo MongoDB