From: Mark M. <mm...@ri...> - 2018-09-07 14:01:27
|
> On Sep 7, 2018, at 3:45 AM, Leopold Palomo-Avellaneda <le...@al...> wrote: > > On 07/09/18 09:12, Leopold Palomo-Avellaneda wrote: >> On 06/09/18 16:04, Mark Moll wrote: >>> Hi Leopold, >>> >>> Yes, unless I made mistake. Patch-level releases should preserve ABI compatibility. >>> >> >> Mark!! >> >> ompl 1.3.3 install libompl.so.14 instead of 13. This is a mistake IMHO. >> > > Mark, > > checking OMPL_ABI_VERSION I have found: > > 1.2.1 -> 12 > 1.3.0 -> 13 > 1.3.1 -> 14 > 1.3.2 -> 14 > 1.3.3 -> 14 > 1.4.0 -> 15 > > Are you aware of this? Pay attention that you jump one number from 1.3.0 and > 1.3.1. and it's a pity because it was easy to remember that the first two digits > means the ABI version. > > I'm preparing a new debian package (1.4.0) and, could be problematic if I patch > OMPL_ABI_VERSION to 14 instead of 15? Hi Leopold, I did a diff between 1.3.0 and 1.3.1 and the API did change slightly. Mostly removing “const” from plain-old-datatypes like int and double in method arguments. I was trying to be cautious and bumped the ABI level, but that may not have been necessary. The ABI number is not derived from the OMPL version. It’s simply a coincidence that at some point it synced up with the first two version numbers. I don’t understand why you would want to patch that. It’s not like anyone needs to remember ABI numbers. To me, it’s just a way for the dynamic library loader to verify that a compatible version is found. So I’d advise against patching the ABI version of OMPL 1.4.0. Best, Mark |