Re: [Omail-ospam] oSpam 0.01 - a system-wide anti-spam solution for qmail and vmailmgr with spamass
Brought to you by:
swix
From: Markus L. <ml...@vt...> - 2003-06-03 19:36:00
|
Olivier, see my comments embedded in your message: > > On Tue, Jun 03, 2003 at 09:36:00AM -0400, Markus Lorch wrote: > > 1. it seems as with the created .qmail files email will be scanned > > for spam twice. Once by nospam, and if that did not delete/move the > > mail then again directly by spamc. Shouldn't we try to modify nospam > > and not run spamc in addition? > > This is because I like to be able to look at the X-Spam lines > afterwards: > > X-Spam-Level: *** > X-Spam-Checker-Version: SpamAssassin 2.54-omnis.ch > (1.174.2.17-2003-05-11-exp) > X-Spam-Report: ---- Start SpamAssassin results > 3.70 points, 5 required; > * 0.8 -- From: does not include a real name > * 0.1 -- BODY: HTML included in message > * 0.1 -- BODY: HTML font color is blue > * 1.4 -- BODY: Message is 10% to 20% HTML > * 1.3 -- Subject contains a unique ID > > > n both (non-spam)-deliverd mail, and also in the spam trash, for > further studies. When using spamc only in the ifspamh script, the > delivered mail would not contain these interesting lines. Yes, I figgured so much. I was just thinking that in the long run we want to modify ifspamh and avoid running the spamc twice. I myself also like the X-headers. So I had a closer look at the ifspamh script and came up with the following: if you replace the exit 0 (clean message) at the very end of the script with the following: # deliver the clean message using local delivery agent delivery=`printf "%s\n" "$output" | $DELIVER` exit $? where at the beginning of the script I set # NEW (Markus Lorch) setting for direct delivery of clean messages DELIVER="/usr/local/nospam/filepipe /usr/local/bin/vdeliver" then you get the scanf headers in the delivered mail and don't need to scan a clean mail again. (i've put a copy of my modified ifspamh at http://www.lorch.net/nospam/ifspamh) thus all that needs to be in the .qmail-ext file is: |/usr/local/nospam/ifspamh sp...@lo... ma...@lo... and if no redirection or "trashing" is wanted, then you can use the following (from your example): |/var/qmail/bin/preline -d /usr/bin/spamc -f -u sca...@om... | /usr/local/nospam/filepipe /usr/local/bin/vdeliver > > > 2. why did you choose not to directly write the .qmail files through > > oadmin? Did you want to avoid changes to oadmin or was it a > privilege > > issue? If it is a privilege issue wouldn't it be better to > use a setuid > > mainly because of the privilege issue: omail-admin is running as web > service, user apache or wwwrun, and can't create/delete these files. > And creating another wrapper, well... I found that my cronjob based > solution would be simpler. understood, I would argue against your point that the current solution is more complex as I have more things that can go wrong and the sequence of the action is somewhat interrupted (the change is done sometime after the user has completed his actions) > > > helper tool to change the settings on demand, than then > rather complex > > approach of checking the DB frequently for changes > > these frequent disk and DB access are normaly pretty well cached > by "modern OS's", so it's not sooo bad, don't you think? :) > (but it's also not optimal, that's sure) I am not concerned about system utilization, don't think thats an issue. > > Improvements suggestions welcome :) > regards, > Olivier > > PS: actual code is under http://omail.omnis.ch/ospam/dev/ > > -- > _________________________________________________________________ > Olivier Mueller - om...@83... - PGPkeyID: 0E84D2EA - Switzerland > qmail projects: http://omail.omnis.ch - http://webmail.omnis.ch > > --------------------------------------------------------------------- > To unsubscribe, e-mail: vma...@li... > For additional commands, e-mail: vma...@li... > |