|
From: Gal N. <gal...@gm...> - 2007-07-11 19:36:20
|
Hi Trevor, > -----Original Message----- > From: ogo...@li... [mailto:ogoglio- > dev...@li...] On Behalf Of Trevor F. Smith > Sent: Wednesday, July 11, 2007 8:20 PM > To: ogo...@li... > Subject: Re: [Ogoglio-developers] [Ogoglio-commits] SF.net SVN: > ogoglio:[224] spaces/trunk/src/com/ogoglio > > Hey, Gal. > > On 7/11/07, Gal Nitzan <gal...@gm...> wrote: > > Thanks for adding the patches... I still need to figure out what goes > where > > :) and how. > > Indeed, there are a lot of moving parts despite my best efforts to > pare it down to the basics. [Gal Nitzan] Until everything is in its place :) > > > In regards to using log4j I believe it to be a better solution than > using > > System.out/err, since we can benefit from the logging levels, changing > > logging level at runtime, code guards etc. > > After using it for several projects I've found that log4j is usually > overkill, code verbose, and misused. The line between debug, warning, > and info aren't at all clear and in general it takes futzing to use > properly. My tactic is to only check in println's for the information > we'd want in the server log for a production machine. During debug > we just use a debugger or add and remove println's as they're needed. > > In addition, log4j is another moving part with its own config file and > API. See my first comment about trying to pare down to the basics. > :-) [Gal Nitzan] Well I'm familiar with the debate logging vs. println :-) fine by me either way. > > > In regards to the space delete issue, I think it make more sense to put > the > > DELETE in the AccountServlet and not in the SpaceServlet. The reason is > that > > since spaces are created in the AccountServlet it would make more sense > to > > delete it in the same place i.e. AccountServlet. Also, since > SpaceServlet > > manages the space's inner data only, I think it is better that the > creation > > and deletion of space stays in the level of the account. > > You make a valid point about my questionable decision to separate POST > and DELETE for space creation and deletion. After looking at the > options I think it makes more sense to move space creation over to > SpaceServlet (where deletion is now) and make the > /og/account/username/space/ resource be a read-only list of an > account's spaces. [Gal Nitzan] Great, it is even a better choice than mine. A good problem domain separation :). > > I'll try to get to that today. [Gal Nitzan] Thanks, Gal > > - Trevor > > ------------------------------------------------------------------------- > This SF.net email is sponsored by DB2 Express > Download DB2 Express C - the FREE version of DB2 express and take > control of your XML. No limits. Just data. Click to get it now. > http://sourceforge.net/powerbar/db2/ > _______________________________________________ > Ogoglio-developers mailing list > Ogo...@li... > https://lists.sourceforge.net/lists/listinfo/ogoglio-developers |