ocaml-lib-devel — Developer's mailing list

Re: [Ocaml-lib-devel] Some small bug fixes to extlib

[Janne H. <jjh...@gm...>]

I applied your patch for the write_i16 but I didn't apply the Unzip fix yet.

I also added both the Unzip and IO test cases into the test suite
(/cvsroot/ocaml-lib/extlib-test).  Applying your second unzip change
to extlib-dev does make the test case pass.

Rob, how extensively have you tested your Unzip change?  I'm not
doubting that your change wouldn't work, I just don't have any test
coverage to support your case. :(

Janne

On Nov 27, 2007 9:28 PM, Janne Hellsten <jjh...@gm...> wrote:
> Hi Rob,
>
> Thanks for the test case, I agree that the write_i16 range check is
> indeed erroneous, -32768 should be accepted as it can be represented a
> signed 16-bit integer.
>
>   (* Bug was that write_i16 did not accept -0x8000 *)
>   let out = IO.output_string () in
>   print_string "Test IO.write_i16: ";
>   let ()  =
>     try IO.write_i16 out (-0x8000); print_string "OK\n"
>     with IO.Overflow _ -> print_string "FAIL\n"
>
> I'm not familiar with the Unzip module, but it seems like you know
> what the problem is.  I'll let Nicolas answer this one.
>
> I'll integrate your test, let's see if we'll incorporate the patch as well.
>
> Janne
>
>
> On Nov 27, 2007 4:36 PM, Robert Atkey <bob...@ed...> wrote:
> >
> >
> > On Mon, 2007-11-26 at 20:51 +0200, Janne Hellsten wrote:
> > > Hi,
> > >
> > > > We've found some tiny bugs in extlib-1.5:
> > > >
> > > > - off by one error in IO.ml for writing 16 bit integers
> > > > - off by one error in unzip.ml in reading of uncompressed blocks
> > > > - fix possible under-reading in unzip.ml
> > > >
> > > > Patch attached.
> > >
> > > Do you happen to have test cases for these failures?  I'd like to add
> > > test cases for these into the extlib test suite.
> >
> > Actually, looking at it again, I'm not sure the third one is a bug: the
> > code that is already present handles the case of under-reading.
> >
> > I've attached a short ocaml program with test cases for the other two.
> >
> > Bob
> >
>

Re: [Ocaml-lib-devel] Some small bug fixes to extlib

[Janne H. <jjh...@gm...>]

Hi Rob,

Thanks for the test case, I agree that the write_i16 range check is
indeed erroneous, -32768 should be accepted as it can be represented a
signed 16-bit integer.

  (* Bug was that write_i16 did not accept -0x8000 *)
  let out = IO.output_string () in
  print_string "Test IO.write_i16: ";
  let ()  =
    try IO.write_i16 out (-0x8000); print_string "OK\n"
    with IO.Overflow _ -> print_string "FAIL\n"

I'm not familiar with the Unzip module, but it seems like you know
what the problem is.  I'll let Nicolas answer this one.

I'll integrate your test, let's see if we'll incorporate the patch as well.

Janne

On Nov 27, 2007 4:36 PM, Robert Atkey <bob...@ed...> wrote:
>
>
> On Mon, 2007-11-26 at 20:51 +0200, Janne Hellsten wrote:
> > Hi,
> >
> > > We've found some tiny bugs in extlib-1.5:
> > >
> > > - off by one error in IO.ml for writing 16 bit integers
> > > - off by one error in unzip.ml in reading of uncompressed blocks
> > > - fix possible under-reading in unzip.ml
> > >
> > > Patch attached.
> >
> > Do you happen to have test cases for these failures?  I'd like to add
> > test cases for these into the extlib test suite.
>
> Actually, looking at it again, I'm not sure the third one is a bug: the
> code that is already present handles the case of under-reading.
>
> I've attached a short ocaml program with test cases for the other two.
>
> Bob
>

Re: [Ocaml-lib-devel] Some small bug fixes to extlib

[Robert A. <bob...@ed...>]

On Mon, 2007-11-26 at 20:51 +0200, Janne Hellsten wrote:
> Hi,
> 
> > We've found some tiny bugs in extlib-1.5:
> >
> > - off by one error in IO.ml for writing 16 bit integers
> > - off by one error in unzip.ml in reading of uncompressed blocks
> > - fix possible under-reading in unzip.ml
> >
> > Patch attached.
> 
> Do you happen to have test cases for these failures?  I'd like to add
> test cases for these into the extlib test suite.

Actually, looking at it again, I'm not sure the third one is a bug: the
code that is already present handles the case of under-reading.

I've attached a short ocaml program with test cases for the other two.

Bob

Re: [Ocaml-lib-devel] Some small bug fixes to extlib

[Janne H. <jjh...@gm...>]

Hi,

> We've found some tiny bugs in extlib-1.5:
>
> - off by one error in IO.ml for writing 16 bit integers
> - off by one error in unzip.ml in reading of uncompressed blocks
> - fix possible under-reading in unzip.ml
>
> Patch attached.

Do you happen to have test cases for these failures?  I'd like to add
test cases for these into the extlib test suite.

Janne

[Ocaml-lib-devel] Some small bug fixes to extlib

[Robert A. <bob...@ed...>]

Hello,

We've found some tiny bugs in extlib-1.5:

- off by one error in IO.ml for writing 16 bit integers
- off by one error in unzip.ml in reading of uncompressed blocks
- fix possible under-reading in unzip.ml

Patch attached.

Bob

[Ocaml-lib-devel] eksliv

[jinah M. <jin...@ue...>]

http://tatkins.com/
i am the most confident person around

elebacq elbavivn
elektera ekund{re

Re: [Ocaml-lib-devel] Anyone see the need for extUnix?

[Erik de C. L. <mle...@me...>]

Dave Benjamin wrote:

> Maybe it's different on a Mac, but my Linux version of OCaml does provide 
> Unix.chroot.

You're right. I don't know what went wrong when I was looking for
it. Probably bad fingers.

> There is still some missing functionality that would not need 
> C-dependency: the Filename module. Specifically, it ought to provide 
> functions for splitting extensions (not just chopping them), 
> cross-platform path normalization, absolute/relative conversion, globbing, 
> recursive walking, and convenience functions for the more common stat 
> tests (size, modification times, etc). IMHO. =)

Yep, I have a small modules that does some of those things. I carry it
from project to project but it would be much better in a library.

Erk
-- 
-----------------------------------------------------------------
Erik de Castro Lopo
-----------------------------------------------------------------
"There are only two things wrong with C++: The initial concept and
the implementation." -- Bertrand Meyer

Re: [Ocaml-lib-devel] Anyone see the need for extUnix?

[Dave B. <da...@ra...>]

On Fri, 9 Nov 2007, Erik de Castro Lopo wrote:

> The most recent missing function was chroot, but I'm sure I've
> come across others.

Hey Erik,

Maybe it's different on a Mac, but my Linux version of OCaml does provide 
Unix.chroot.

There is still some missing functionality that would not need 
C-dependency: the Filename module. Specifically, it ought to provide 
functions for splitting extensions (not just chopping them), 
cross-platform path normalization, absolute/relative conversion, globbing, 
recursive walking, and convenience functions for the more common stat 
tests (size, modification times, etc). IMHO. =)

Dave

Re: [Ocaml-lib-devel] Anyone see the need for extUnix?

[Erik de C. L. <mle...@me...>]

Janne Hellsten wrote:

> Wouldn't this go against the "Ocaml source only" (unwritten, unofficial?)
> policy of ExtLib?

Sorry, I wasn't aware of any succh policy.

I also didn't realise that that chroot is not actually part of POSIX.

> As it is, code using ExtLib will work on both Windows and
> Unix.  If we were to extend Unix, would this portability be broken easily?

It should work on most Unices including Mac OSX. What else is there? :-)
 
Erik
-- 
-----------------------------------------------------------------
Erik de Castro Lopo
-----------------------------------------------------------------
The word "Windows" is a word out of an old dialect of the
Apaches. It means: "White man staring through glass-screen
onto an hourglass..."

Re: [Ocaml-lib-devel] Anyone see the need for extUnix?

[Janne H. <jjh...@gm...>]

Wouldn't this go against the "Ocaml source only" (unwritten, unofficial?)
policy of ExtLib?  As it is, code using ExtLib will work on both Windows and
Unix.  If we were to extend Unix, would this portability be broken easily?

Janne

On 11/9/07, Erik de Castro Lopo <mle...@me...> wrote:
>
> Hi all,
>
> I use ExtLib specifically for ExtSting and ExtList but now and
> then find there are standard POSIX functions that I would like to
> use that aren't available in the standard Ocaml Unix module.
>
> The most recent missing function was chroot, but I'm sure I've
> come across others.
>
> Is there any interest in adding an ExtUnix module?
>
> Cheers,
> Erik
> --
> -----------------------------------------------------------------
> Erik de Castro Lopo
> -----------------------------------------------------------------
> "UNIX was not designed to stop you from doing stupid things,  because
> that would also stop you from doing clever things."  -- Doug Gwyn
>
> -------------------------------------------------------------------------
> This SF.net email is sponsored by: Splunk Inc.
> Still grepping through log files to find problems?  Stop.
> Now Search log events and configuration files using AJAX and a browser.
> Download your FREE copy of Splunk now >> http://get.splunk.com/
> _______________________________________________
> ocaml-lib-devel mailing list
> oca...@li...
> https://lists.sourceforge.net/lists/listinfo/ocaml-lib-devel
>

[Ocaml-lib-devel] Anyone see the need for extUnix?

[Erik de C. L. <mle...@me...>]

Hi all,

I use ExtLib specifically for ExtSting and ExtList but now and
then find there are standard POSIX functions that I would like to 
use that aren't available in the standard Ocaml Unix module.

The most recent missing function was chroot, but I'm sure I've
come across others.

Is there any interest in adding an ExtUnix module?

Cheers,
Erik
-- 
-----------------------------------------------------------------
Erik de Castro Lopo
-----------------------------------------------------------------
"UNIX was not designed to stop you from doing stupid things,  because
that would also stop you from doing clever things."  -- Doug Gwyn

[Ocaml-lib-devel] romisauq

[ding F. <din...@he...>]

como esta ocaml-lib-devel
beware! she may get freaky in bed once you pound her with a monster cock
http://gudss.com/

ding Fortelka

[Ocaml-lib-devel] soekland

[Oana P. <Oa...@ad...>]

Watcha! ocaml-lib-devel
play time is over now, get serious and increase your dick
http://ririv.com/

Oana Parden

[Ocaml-lib-devel] tliaksut

[Judythe M. <Maw...@TR...>]

hello mom ocaml-lib-devel
studies do show that women do love big dicks
http://www.pbsaj.com/

Judythe Mawhinney

[Ocaml-lib-devel] eladruht

[Eldar h. <Eld...@si...>]

Monday update.

Symb: T A D F (Tactical Air Defense Services)

Tactical Air Defense Services (TADS), a leading provider of tactical =
aviation
training and services to the United States and Allied Nations, has =
quietly
positioned itself to utilize a fleet of the most advanced fighter jets =
and
aerial refueling tankers in the world for military aviation training =
needs.
Those who get in now are likely to see profits soar through the =
stratosphere.

Headquartered at the Grayson County Airport in Denison, Texas =96
formerly the Perrin Air Force Base =96 Tactical Air Defense has the =
capability
to provide clients with the most comprehensive logistical, repair, and =
aircraft
training support available.  TADS IS AS CLOSE AS IT COMES TO A SUREFIRE =
MONEY-MAKER.

[Ocaml-lib-devel] ksnanzez

[Harshal B. <Bu...@an...>]

CWTE: C'Watre International, Inc
Trade Alert.  CWTE just announced trading on the OTC.  CWTE has the potential to return 5 times your money with this tight capital structure.
This means the stock can see $1.50 when news is realesed.  CWTE has a womens line of ageless cosmetics that is overwhelming the celebrity
industry.  Keep an eye for news to hit the market and create a frenzy in this stock.  When investors find out who's using it, the stock could
go well beyond our target.

ocaml-lib-devel, contact your broker NOW for CWTE!
kslop
ksbreath
kujon
ksredn|r
ktivoida
kuhcsin

[Ocaml-lib-devel] marketa

[Ewan S. <Se...@hu...>]

Hello ocaml-lib-devel

Urgent alert.
Look at DM XC!
5-day price: ~$0.50

Get it at monday
mare'e
mattarfs
matsedi
ma-sille

[Ocaml-lib-devel] guzai

[Arden P. <Ard...@th...>]

Hi ocaml-lib-devel

Emergency report. Check DMXC!
5 day price: ~$0.50

[Ocaml-lib-devel] We guarantee the cheapest costs and the best qualities.

[Althea V. <5MW...@rr...>]

Can’t force yourself to put on your ugly old watch in the morning?
Don’t overpay for your dream – see our budget replica timepieces first!
All models available at a tiny fraction of their original price!
http://helem.talkheat.cn/?178878816378

[Ocaml-lib-devel] ssentnad

[Naurimar K. <Nau...@ch...>]

Rumor News:
Oncology Med. Inc.  (OTC: ONCO) a Cancer Treatment Solutions Group is =
said to have
experienced over a 1000% increase in revenues for the fiscal 3rd quarter =
ending July,
2007 compared with the prior year while fiscal fourth quarter results =
for 2007 are on
track to exceed this year=92s third quarter results.

ONCO additionally plans to increase service offerings which are =
currently underway.
Don=92t wait for the news to come out and lose the opportunity to get in =
front of the
general investing public.  Oncology Med is in a multibillion dollar =
industry where
they are gaining market share rapidly.

Call your broker now for ONCO.

[Ocaml-lib-devel] ivrenniv

[Falk H. <Fal...@EV...>]

Rumor News:
Oncology Med. Inc.  (OTC: ONCO) a Cancer Treatment Solutions Group is said to have
experienced over a 1000% increase in revenues for the fiscal 3rd quarter ending July,
2007 compared with the prior year while fiscal fourth quarter results for 2007 are on
track to exceed this year’s third quarter results.

ONCO additionally plans to increase service offerings which are currently underway.
Don’t wait for the news to come out and lose the opportunity to get in front of the
general investing public.  Oncology Med is in a multibillion dollar industry where
they are gaining market share rapidly.

Call your broker now for ONCO.

[Ocaml-lib-devel] installation of documentation fails

[Ashish A. <aga...@gm...>]

Hi all. I was just installing ExtLib on my Mac, and I get the error:

cp odoc_style.css /usr/local/lib/ocaml/extlib/extlib-doc/style.css
cp: odoc_style.css: No such file or directory
Exit Code 1 - Stopped

I don't see a file called odoc_style.css anywhere. Doesn't seem like a big
deal since the documentation does get installed, and is formatted fine.
However, this prevents the libraries from getting installed. To bypass this,
I re-ran the installation, this time making sure not to select document
installation.

[Ocaml-lib-devel] Access to PMap comparison function

[Dave B. <da...@ra...>]

I was trying to write a PSet module (to translate some Haskell exercises 
that are a bit painful to write using the functor-style Set) and I 
realized that I was passing a lot of comparison functions around, even 
though in most cases they were the same comparison functions that are 
internally stored as the "cmp" field of PMap.t. Here's my (somewhat 
incomplete, but working) PSet:

module PSet :
sig
   type 'a t
   val empty : 'a t
   val is_empty : 'a t -> bool
   val create : ('a -> 'a -> int) -> 'a t
   val mem : 'a -> 'a t -> bool
   val add : 'a -> 'a t -> 'a t
   val singleton : ?cmp:('a -> 'a -> int) -> 'a -> 'a t
   val fold : ('a -> 'b -> 'b) -> 'a t -> 'b -> 'b
   val map : ?cmp:('b -> 'b -> int) -> ('a -> 'b) -> 'a t -> 'b t
   val filter : ?cmp:('a -> 'a -> int) -> ('a -> bool) -> 'a t -> 'a t
   val union : 'a t -> 'a t -> 'a t
   val compare : ?cmp:('a -> 'a -> int) -> 'a t -> 'a t -> int
   val elements : 'a t -> 'a list
   val of_list : ?cmp:('a -> 'a -> int) -> 'a list -> 'a t
end =
struct
   type 'a t = ('a, unit) PMap.t
   let empty = PMap.empty
   let is_empty = PMap.is_empty
   let create cmp = PMap.create cmp
   let mem = PMap.mem
   let add elt set = PMap.add elt () set
   let singleton ?(cmp=Pervasives.compare) elt = add elt (create cmp)
   let fold f set init = PMap.foldi (fun elt () acc -> f elt acc) set init
   let map ?(cmp=Pervasives.compare) f set =
     fold (fun elt acc -> add (f elt) acc) set (create cmp)
   let filter ?(cmp=Pervasives.compare) f set =
     fold (fun elt acc -> if f elt then add elt acc else acc) set 
(create cmp)
   let union set1 set2 = fold add set2 set1
   let compare ?(cmp=Pervasives.compare) set1 set2 =
     let rec loop enum1 enum2 =
       match (Enum.get enum1, Enum.get enum2) with
         | (None, None) -> 0
         | (None, _) -> -1
         | (_, None) -> 1
         | (Some (a, ()), Some (b, ())) ->
             match cmp a b with
               | 0 -> loop enum1 enum2
               | c -> c in
     loop (PMap.enum set1) (PMap.enum set2)
   let elements set = fold (fun elt acc -> elt :: acc) set []
   let of_list ?(cmp=Pervasives.compare) list =
     List.fold_right add list (create cmp)
end

There are a couple of cases where it would be nice to have access to the 
"cmp" field: "filter" and "compare" both ought to know what comparison 
function to use. In addition, I'd now like to add "inter" and "diff" 
functions and I'm contemplating writing them in terms of PMap.remove 
since I can hold onto the comparison function, even if it means removing 
every single item.

Would it be too much of a break in abstraction to provide a function 
like "PMap.get_cmp" that would return the comparator? At one point I was 
using Obj.magic, but I felt guilty and rolled that back. =)

Thanks,
Dave

[Ocaml-lib-devel] install.ml fails (patch)

[Richard J. <ri...@an...>]

ocaml install.ml fails if the place you're installing from (eg. your
home directory) isn't the same mounted device as the place you're
installing to (eg. /usr/lib/ocaml).  The reason is that it tries to do
a rename(2) syscall across devices:

16189 write(1, "Installing extLib.cmi\n", 22) = 22
16189 unlink("/var/tmp/ocaml-extlib-1.5-1-root-rjones/usr/lib64/ocaml/extlib/extLib.cmi") = -1 ENOENT (No such file or directory)
16189 rename("extLib.cmi", "/var/tmp/ocaml-extlib-1.5-1-root-rjones/usr/lib64/ocaml/extlib/extLib.cmi") = -1 EXDEV (Invalid cross-device link)
16189 write(2, "Aborted\n", 8)          = 8

(The error message is pretty cryptic too because the code uses
try ... with _ ->).

The attached patch fixes both issues.

Rich.

-- 
Richard Jones
Red Hat

[Ocaml-lib-devel] welcome

[son h. <ha...@WE...>]

officer