From: Brian H. <bh...@sp...> - 2004-09-10 21:48:34
|
On Fri, 10 Sep 2004, Nicolas Cannasse wrote: > I would rename Idxtree to IdxTree , using a maj T for case. OK. > > search_index instead of find_index would be more consistent. You're right. They were originally find and find_index, but I didn't like changing the semantics of find, so I changed it's name to search, but didn't change find_index. Thinko. > > I would also drop the O(N) notations were it's obvious that all elements are > browsed : of_list / to_array / iter / fold for example. No. They could be O(N log N) implemented poorly. For example: let iter f idxtree = for i = 0 to (length idxtree) - 1 do f (get idxtree i) done ;; I am explicitly disallowing this implementation. > I would also remove > rev_enum and of_rev_enum which are a little bit particular and can be > acheived using to_enum + rev or of_enum + rev. At additional cost. But I'm not sure how usefull these functions really are. Anyone else have an opinion they'd like to weigh in with? > > And I would add iteri + mapi functions. Good idea. > > It has my approval for inclusion into ExtLib. You can commit it on CVS right > now or wait for more people insights. I'll look at checking it in. -- "Usenet is like a herd of performing elephants with diarrhea -- massive, difficult to redirect, awe-inspiring, entertaining, and a source of mind-boggling amounts of excrement when you least expect it." - Gene Spafford Brian |