[OJB-developers] Proposal for enhancing org.apache.commons.logging.Log

[Jakob B. <jbr...@gm...>]

hi,

i'd like to propose some enhancements to the org.apache.commons.logging.Log
interface:

void debug(Object aMessage, Object aParameter)
void debug(Object aMessage, Object aParameter, Throwable anException);

the same extension should be done for methods info, error and fatal.

what's the benefit of this new methods:

a.) the ojb team (http://jakarta.apache.org/ojb) needs a lot of logging
where user objects are part of the logging-string.

logger.debug("deleting " + obj);

we had the problem that in some cases the toString() of the user object
failed, which alse broke our logging.
the proposed enhancements would allow as to use:

logger.debug("deleting", obj);

and all implementation details of the failsafe logging methods with
try/catch around toString() could be hidden.

b.) the toString() method of some objects may be  costly and it should only
be done when the loglevel mathes.
i know there are methods to query the loglevel isDebugEnabled() bit imho the
logging-call should be a simple one liner.

c.) java.util.logging of jdk 1.4 also supports parameters.

thanks

jakob