Menu ▾ ▴

#783 Unresolved procedure commands shall throw an error

v1.1.x
closed
Erik Hänel
internal (109) cmd (19) errorhandling (2)
v1.1.5
Change Request
2023-02-17
2023-02-05
Erik Hänel
No

Unresolved procedure commands, which are only interpreted in procedures an not used in scripts or the terminal shall throw a corresponding error describing the misuse. Add this to the static code analyzer as well.

Analysis:

Needs a new error and a new analyzer detection point. Is kind of straightforward.

Implementation:

  • Implementation: Implemented as proposed by the analysis. Already existing errors and detection points were generalized and re-used.
  • Revision: [r1320]
  • Implementation test: Procedure commands were used in terminal or scripts and corresponding errors were thrown.

Documentation:

  • [x] ChangesLog updated
  • [x] Code changes commented
  • Documentation articles:
    • [ ] corresponding documentation articles updated
    • [ ] new documentation articles created
    • [x] not needed
  • Language files:
    • [x] corresponding language files updated
    • [ ] not needed

Tests:

Had to be tested manually. Not all keywords were tested. Deviation resolved [r1335].

Related

Commit: [r1320]
Commit: [r1335]

Discussion

  • Erik Hänel

    Erik Hänel - 2023-02-05
    • labels: --> internal, cmd, errorhandling
     

  • Erik Hänel

    Erik Hänel - 2023-02-05
    • status: open --> accepted
     

  • Erik Hänel

    Erik Hänel - 2023-02-05
    • Description has changed:

    Diff:

    --- old
+++ new
@@ -1 +1,23 @@
 Unresolved procedure commands, which are only interpreted in procedures an not used in scripts or the terminal shall throw a corresponding error describing the misuse. Add this to the static code analyzer as well.
+
+###Analysis:
+(*Describe, what's the issue and which changes have to be made*)
+
+###Implementation:
+* Implementation: (*Describe, what you've changed*) 
+* Revision: [rXXX]
+* Implementation test: (*Describe the type of test, which you performed, and if it was successful*)
+
+###Documentation:
+* [ ] ChangesLog updated
+* [ ] Code changes commented
+* **Documentation articles:**

+    * [ ] corresponding documentation articles updated
+    * [ ] new documentation articles created
+    * [ ] not needed
+* **Language files:**
+    * [ ] corresponding language files updated
+    * [ ] not needed
+
+###Tests:
+(*Describe, which tests you performed and their outcome*)
    • status: accepted --> analyzing
     

  • Erik Hänel

    Erik Hänel - 2023-02-07
    • Description has changed:

    Diff:

    --- old
+++ new
@@ -1,7 +1,7 @@
 Unresolved procedure commands, which are only interpreted in procedures an not used in scripts or the terminal shall throw a corresponding error describing the misuse. Add this to the static code analyzer as well.

 ###Analysis:
-(*Describe, what's the issue and which changes have to be made*)
+Needs a new error and a new analyzer detection point. Is kind of straightforward.

 ###Implementation:

 * Implementation: (*Describe, what you've changed*)
    • status: analyzing --> implementing
     

  • Erik Hänel

    Erik Hänel - 2023-02-07
    • Description has changed:

    Diff:

    --- old
+++ new
@@ -4,19 +4,19 @@
 Needs a new error and a new analyzer detection point. Is kind of straightforward.

 ###Implementation:
-* Implementation: (*Describe, what you've changed*) 
-* Revision: [rXXX]
-* Implementation test: (*Describe the type of test, which you performed, and if it was successful*)
+* Implementation: Implemented as proposed by the analysis. Already existing errors and detection points were generalized and re-used.
+* Revision: [r1320]
+* Implementation test: Procedure commands were used in terminal or scripts and corresponding errors were thrown.

 ###Documentation:
-* [ ] ChangesLog updated
-* [ ] Code changes commented
+* [x] ChangesLog updated
+* [x] Code changes commented

 * **Documentation articles:**
     * [ ] corresponding documentation articles updated
     * [ ] new documentation articles created
-    * [ ] not needed
+    * [x] not needed
 * **Language files:**
-    * [ ] corresponding language files updated
+    * [x] corresponding language files updated
     * [ ] not needed

 ###Tests:
    • status: implementing --> testing
     

    Related

    Commit: [r1320]

  • Erik Hänel

    Erik Hänel - 2023-02-17
    • Description has changed:

    Diff:

    --- old
+++ new
@@ -20,4 +20,4 @@

     * [ ] not needed

 ###Tests:
-(*Describe, which tests you performed and their outcome*)
+Had to be tested manually. Not all keywords were tested. Deviation resolved [r1335].
    • status: testing --> closed
     

    Related

    Commit: [r1335]

Anonymous
Anonymous

Add attachments
Cancel





MongoDB Logo MongoDB