Menu ▾ ▴

#781 Brace autocompletion does not work on non-DE keyboards

v1.1.x
fixed
Erik Hänel
critical (96) editor (22)
v1.1.3
Bug Fix
2023-02-14
2023-02-03
Erik Hänel
No

The brace autocompletion is tied to physical keys on the keyboard and not to the actual created character. Change this to enable full autocompletion on non-german keyboards.

Analysis:

Instead of hooking into the OnKeyDown event, we will have to solve the complete logic on the OnChar handler. To enable this, we'll kind of store the state in the OnKeyDown event and use this information to replicate the correct behavior in the OnChar handler.

Implementation:

  • Implementation: Fix was implemented as proposed by the analysis.
  • Revision: [r1318]
  • Implementation test: Braces of different types were entered (also in combination with a selection). Brace autocompletion worked as expected.

Documentation:

  • [x] ChangesLog updated
  • [ ] Code changes commented
  • Documentation articles:
    • [ ] corresponding documentation articles updated
    • [ ] new documentation articles created
    • [x] not needed
  • Language files:
    • [ ] corresponding language files updated
    • [x] not needed

Tests:

Fix was tested on a US keyboard layout. Autocompletion works as expected.

Related

Commit: [r1318]

Discussion

  • Erik Hänel

    Erik Hänel - 2023-02-03
    • status: open --> accepted
     

  • Erik Hänel

    Erik Hänel - 2023-02-03
    • Description has changed:

    Diff:

    --- old
+++ new
@@ -1 +1,23 @@
 The brace autocompletion is tied to physical keys on the keyboard and not to the actual created character. Change this to enable full autocompletion on non-german keyboards.
+
+###Analysis:
+(*Describe, what's the issue and which changes have to be made*)
+
+###Implementation:
+* Implementation: (*Describe, what you've changed*) 
+* Revision: [rXXX]
+* Implementation test: (*Describe the type of test, which you performed, and if it was successful*)
+
+###Documentation:
+* [ ] ChangesLog updated
+* [ ] Code changes commented
+* **Documentation articles:**

+    * [ ] corresponding documentation articles updated
+    * [ ] new documentation articles created
+    * [ ] not needed
+* **Language files:**
+    * [ ] corresponding language files updated
+    * [ ] not needed
+
+###Tests:
+(*Describe, which tests you performed and their outcome*)
    • status: accepted --> analyzing
     

  • Erik Hänel

    Erik Hänel - 2023-02-03
    • Description has changed:

    Diff:

    --- old
+++ new
@@ -1,7 +1,7 @@
 The brace autocompletion is tied to physical keys on the keyboard and not to the actual created character. Change this to enable full autocompletion on non-german keyboards.

 ###Analysis:
-(*Describe, what's the issue and which changes have to be made*)
+Instead of hooking into the OnKeyDown event, we will have to solve the complete logic on the OnChar handler. To enable this, we'll kind of store the state in the OnKeyDown event and use this information to replicate the correct behavior in the OnChar handler.

 ###Implementation:

 * Implementation: (*Describe, what you've changed*)
    • status: analyzing --> implementing
     

  • Erik Hänel

    Erik Hänel - 2023-02-05
    • Description has changed:

    Diff:

    --- old
+++ new
@@ -4,20 +4,20 @@
 Instead of hooking into the OnKeyDown event, we will have to solve the complete logic on the OnChar handler. To enable this, we'll kind of store the state in the OnKeyDown event and use this information to replicate the correct behavior in the OnChar handler.

 ###Implementation:
-* Implementation: (*Describe, what you've changed*) 
-* Revision: [rXXX]
-* Implementation test: (*Describe the type of test, which you performed, and if it was successful*)
+* Implementation: Fix was implemented as proposed by the analysis.
+* Revision: [r1318]
+* Implementation test: Braces of different types were entered (also in combination with a selection). Brace autocompletion worked as expected.

 ###Documentation:
-* [ ] ChangesLog updated
+* [x] ChangesLog updated

 * [ ] Code changes commented
 * **Documentation articles:**
     * [ ] corresponding documentation articles updated
     * [ ] new documentation articles created
-    * [ ] not needed
+    * [x] not needed
 * **Language files:**
     * [ ] corresponding language files updated
-    * [ ] not needed
+    * [x] not needed

 ###Tests:
 (*Describe, which tests you performed and their outcome*)
    • status: implementing --> testing
     

    Related

    Commit: [r1318]

  • Erik Hänel

    Erik Hänel - 2023-02-14
    • Description has changed:

    Diff:

    --- old
+++ new
@@ -20,4 +20,4 @@

     * [x] not needed

 ###Tests:
-(*Describe, which tests you performed and their outcome*)
+Fix was tested on a US keyboard layout. Autocompletion works as expected.
    • status: testing --> fixed
     

Anonymous
Anonymous

Add attachments
Cancel





MongoDB Logo MongoDB