Menu ▾ ▴

#779 Add checks for the correct column type in all necessary commands

v1.1.x
closed
Erik Hänel
internal (109) cmd (19)
v1.1.5
Change Request
2023-03-04
2023-01-10
Erik Hänel
No

Commands should evaluate, whether the passed dataset actually contains valid data columns (i.e. if a command needs numerical values, the column type should not be string). Especially valid for spline.

Analysis:

For simplification, we'll create a central method to query, whether the selected columns do actually only contain numerical data. Using this, it's only a matter of going through each command, adding the check and throw an error if necessary.

Implementation:

  • Implementation: Implemented as proposed by the analysis.
  • Revision: [r1317]
  • Implementation test: Some commands were tested with wrong data types and the error was thrown.

Documentation:

  • [x] ChangesLog updated
  • [x] Code changes commented
  • Documentation articles:
    • [ ] corresponding documentation articles updated
    • [ ] new documentation articles created
    • [x] not needed
  • Language files:
    • [x] corresponding language files updated
    • [ ] not needed

Tests:

Tested the new checks with some random commands. No deviation was detected.

Related

Commit: [r1317]

Discussion

  • Erik Hänel

    Erik Hänel - 2023-01-13
    • labels: --> internal, cmd
    • status: open --> accepted
     

  • Erik Hänel

    Erik Hänel - 2023-01-13
    • Description has changed:

    Diff:

    --- old
+++ new
@@ -1 +1,23 @@
 Commands should evaluate, whether the passed dataset actually contains valid data columns (i.e. if a command needs numerical values, the column type should not be `string`). Especially valid for `spline`.
+
+###Analysis:
+(*Describe, what's the issue and which changes have to be made*)
+
+###Implementation:
+* Implementation: (*Describe, what you've changed*) 
+* Revision: [rXXX]
+* Implementation test: (*Describe the type of test, which you performed, and if it was successful*)
+
+###Documentation:
+* [ ] ChangesLog updated
+* [ ] Code changes commented
+* **Documentation articles:**

+    * [ ] corresponding documentation articles updated
+    * [ ] new documentation articles created
+    * [ ] not needed
+* **Language files:**
+    * [ ] corresponding language files updated
+    * [ ] not needed
+
+###Tests:
+(*Describe, which tests you performed and their outcome*)
    • status: accepted --> analyzing
     

  • Erik Hänel

    Erik Hänel - 2023-01-31
    • Description has changed:

    Diff:

    --- old
+++ new
@@ -1,7 +1,7 @@
 Commands should evaluate, whether the passed dataset actually contains valid data columns (i.e. if a command needs numerical values, the column type should not be `string`). Especially valid for `spline`.

 ###Analysis:
-(*Describe, what's the issue and which changes have to be made*)
+For simplification, we'll create a central method to query, whether the selected columns do actually only contain numerical data. Using this, it's only a matter of going through each command, adding the check and throw an error if necessary.

 ###Implementation:

 * Implementation: (*Describe, what you've changed*)
    • status: analyzing --> implementing
     

  • Erik Hänel

    Erik Hänel - 2023-02-02
    • Description has changed:

    Diff:

    --- old
+++ new
@@ -4,19 +4,19 @@
 For simplification, we'll create a central method to query, whether the selected columns do actually only contain numerical data. Using this, it's only a matter of going through each command, adding the check and throw an error if necessary.

 ###Implementation:
-* Implementation: (*Describe, what you've changed*) 
-* Revision: [rXXX]
-* Implementation test: (*Describe the type of test, which you performed, and if it was successful*)
+* Implementation: Implemented as proposed by the analysis.
+* Revision: [r1317]
+* Implementation test: Some commands were tested with wrong data types and the error was thrown.

 ###Documentation:
-* [ ] ChangesLog updated
-* [ ] Code changes commented
+* [x] ChangesLog updated
+* [x] Code changes commented

 * **Documentation articles:**
     * [ ] corresponding documentation articles updated
     * [ ] new documentation articles created
-    * [ ] not needed
+    * [x] not needed
 * **Language files:**
-    * [ ] corresponding language files updated
+    * [x] corresponding language files updated
     * [ ] not needed

 ###Tests:
    • status: implementing --> testing
     

    Related

    Commit: [r1317]

  • Erik Hänel

    Erik Hänel - 2023-03-04
    • Description has changed:

    Diff:

    --- old
+++ new
@@ -20,4 +20,4 @@

     * [ ] not needed

 ###Tests:
-(*Describe, which tests you performed and their outcome*)
+Tested the new checks with some random commands. No deviation was detected.
    • status: testing --> closed
     

Anonymous
Anonymous

Add attachments
Cancel





MongoDB Logo MongoDB