Menu

#751 Icons do not work in layouts

v1.1.x
fixed
v1.1.4
Bug Fix
2023-02-16
2022-10-19
Erik Hänel
No

Icons do not work in layouts. The system seems not to find them.

Analysis:

There are two problems:

  • the image handler for the icons is incorrect
  • path placeholders are not resolved

Implementation:

  • Implementation: Resolved both issues as described in the analysis.
  • Revision: [r1244]
  • Implementation test: Added a custom icon in ICO and PNG format and it was displayed as expected.

Documentation:

  • [x] ChangesLog updated
  • [x] Code changes commented
  • Documentation articles:
    • [ ] corresponding documentation articles updated
    • [ ] new documentation articles created
    • [x] not needed
  • Language files:
    • [ ] corresponding language files updated
    • [x] not needed

Tests:

Fix was tested manually. No deviation detected.

Related

Commit: [r1244]

Discussion

  • Erik Hänel

    Erik Hänel - 2022-10-19
    • labels: --> windows, gui
    • status: open --> accepted
     
  • Erik Hänel

    Erik Hänel - 2022-10-19
    • Description has changed:

    Diff:

    --- old
    +++ new
    @@ -1 +1,23 @@
     Icons do not work in layouts. The system seems not to find them.
    +
    +###Analysis:
    +(*Describe, what's the issue and which changes have to be made*)
    +
    +###Implementation:
    +* Implementation: (*Describe, what you've changed*) 
    +* Revision: [rXXX]
    +* Implementation test: (*Describe the type of test, which you performed, and if it was successful*)
    +
    +###Documentation:
    +* [ ] ChangesLog updated
    +* [ ] Code changes commented
    +* **Documentation articles:**
    
    +    * [ ] corresponding documentation articles updated
    +    * [ ] new documentation articles created
    +    * [ ] not needed
    +* **Language files:**
    +    * [ ] corresponding language files updated
    +    * [ ] not needed
    +
    +###Tests:
    +(*Describe, which tests you performed and their outcome*)
    
    • status: accepted --> analyzing
     
  • Erik Hänel

    Erik Hänel - 2022-10-19
    • Description has changed:

    Diff:

    --- old
    +++ new
    @@ -1,7 +1,10 @@
     Icons do not work in layouts. The system seems not to find them.
    
     ###Analysis:
    -(*Describe, what's the issue and which changes have to be made*)
    +There are two problems:
    +
    +* the image handler for the icons is incorrect
    +* path placeholders are not resolved
    
     ###Implementation:
    
     * Implementation: (*Describe, what you've changed*) 
    
    • status: analyzing --> implementing
     
  • Erik Hänel

    Erik Hänel - 2022-10-19
    • Description has changed:

    Diff:

    --- old
    +++ new
    @@ -7,20 +7,20 @@
    
     * path placeholders are not resolved
    
     ###Implementation:
    -* Implementation: (*Describe, what you've changed*) 
    -* Revision: [rXXX]
    -* Implementation test: (*Describe the type of test, which you performed, and if it was successful*)
    +* Implementation: Resolved both issues as described in the analysis.
    +* Revision: [r1244]
    +* Implementation test: Added a custom icon in ICO and PNG format and it was displayed as expected.
    
     ###Documentation:
    -* [ ] ChangesLog updated
    -* [ ] Code changes commented
    +* [x] ChangesLog updated
    +* [x] Code changes commented
    
     * **Documentation articles:**
         * [ ] corresponding documentation articles updated
         * [ ] new documentation articles created
    -    * [ ] not needed
    +    * [x] not needed
     * **Language files:**
         * [ ] corresponding language files updated
    -    * [ ] not needed
    +    * [x] not needed
    
     ###Tests:
     (*Describe, which tests you performed and their outcome*)
    
    • status: implementing --> testing
     

    Related

    Commit: [r1244]

  • Erik Hänel

    Erik Hänel - 2023-02-16
    • Description has changed:

    Diff:

    --- old
    +++ new
    @@ -23,4 +23,4 @@
    
         * [x] not needed
    
     ###Tests:
    -(*Describe, which tests you performed and their outcome*)
    +Fix was tested manually. No deviation detected.
    
    • status: testing --> fixed
     

Anonymous
Anonymous

Add attachments
Cancel