Menu ▾ ▴

#664 Remove superfluous indents during installs

v1.1.x
fixed
Erik Hänel
gui (58) packages (4) installs (1)
v1.1.3
Bug Fix
2022-03-11
2022-02-11
Erik Hänel
No

During installs of procedures using the new <file> ... <endfile> blocks, a superfluous indentation is added at the beginning of every line. This indentation should be removed before the files contents are written to a file.

Analysis:

This can be implemented by buffering the files contents and determining the superfluous indent depth. This indent can then be removed while writing the buffer to the actual file.

Implementation:

  • Implementation: Implemented as proposed by the analysis.
  • Revision: [r1067]
  • Implementation test: The fix was tested manually. Indents were replaced by four whitespaces and superfluous indents are omitted.

Documentation:

  • [x] ChangesLog updated
  • [x] Code changes commented
  • Documentation articles:
    • [ ] corresponding documentation articles updated
    • [ ] new documentation articles created
    • [x] not needed
  • Language files:
    • [ ] corresponding language files updated
    • [x] not needed

Tests:

A package was installed using the new <file ...>...<endfile> tags and the indentations were preserved (although converted to whitespaces).

Related

Commit: [r1067]

Discussion

  • Erik Hänel

    Erik Hänel - 2022-02-11
    • labels: --> gui, packages, installs
    • status: open --> accepted
     

  • Erik Hänel

    Erik Hänel - 2022-02-12
    • Description has changed:

    Diff:

    --- old
+++ new
@@ -1 +1,23 @@
 During installs of procedures using the new `&lt;file&gt; ... &lt;endfile&gt;` blocks, a superfluous indentation is added at the beginning of every line. This indentation should be removed before the files contents are written to a file.
+
+###Analysis:
+(*Describe, what&#39;s the issue and which changes have to be made*)
+
+###Implementation:
+* Implementation: (*Describe, what you&#39;ve changed*) 
+* Revision: [rXXX]
+* Implementation test: (*Describe the type of test, which you performed, and if it was successful*)
+
+###Documentation:
+* [ ] ChangesLog updated
+* [ ] Code changes commented
+* **Documentation articles:**

+    * [ ] corresponding documentation articles updated
+    * [ ] new documentation articles created
+    * [ ] not needed
+* **Language files:**
+    * [ ] corresponding language files updated
+    * [ ] not needed
+
+###Tests:
+(*Describe, which tests you performed and their outcome*)
    • status: accepted --> analyzing
     

  • Erik Hänel

    Erik Hänel - 2022-02-12
    • Description has changed:

    Diff:

    --- old
+++ new
@@ -1,7 +1,7 @@
 During installs of procedures using the new `&lt;file&gt; ... &lt;endfile&gt;` blocks, a superfluous indentation is added at the beginning of every line. This indentation should be removed before the files contents are written to a file.

 ###Analysis:
-(*Describe, what&#39;s the issue and which changes have to be made*)
+This can be implemented by buffering the files contents and determining the superfluous indent depth. This indent can then be removed while writing the buffer to the actual file.

 ###Implementation:

 * Implementation: (*Describe, what you&#39;ve changed*)
    • status: analyzing --> implementing
     

  • Erik Hänel

    Erik Hänel - 2022-02-12
    • Description has changed:

    Diff:

    --- old
+++ new
@@ -4,20 +4,20 @@
 This can be implemented by buffering the files contents and determining the superfluous indent depth. This indent can then be removed while writing the buffer to the actual file.

 ###Implementation:
-* Implementation: (*Describe, what you&#39;ve changed*) 
-* Revision: [rXXX]
-* Implementation test: (*Describe the type of test, which you performed, and if it was successful*)
+* Implementation: Implemented as proposed by the analysis.
+* Revision: [r1067]
+* Implementation test: The fix was tested manually. Indents were replaced by four whitespaces and superfluous indents are omitted.

 ###Documentation:
-* [ ] ChangesLog updated
-* [ ] Code changes commented
+* [x] ChangesLog updated
+* [x] Code changes commented

 * **Documentation articles:**
     * [ ] corresponding documentation articles updated
     * [ ] new documentation articles created
-    * [ ] not needed
+    * [x] not needed
 * **Language files:**
     * [ ] corresponding language files updated
-    * [ ] not needed
+    * [x] not needed

 ###Tests:
 (*Describe, which tests you performed and their outcome*)
    • status: implementing --> testing
     

    Related

    Commit: [r1067]

  • Erik Hänel

    Erik Hänel - 2022-03-11
    • Description has changed:

    Diff:

    --- old
+++ new
@@ -20,4 +20,4 @@

     * [x] not needed

 ###Tests:
-(*Describe, which tests you performed and their outcome*)
+A package was installed using the new `&lt;file ...&gt;...&lt;endfile&gt;` tags and the indentations were preserved (although converted to whitespaces).
    • status: testing --> fixed
     

Anonymous
Anonymous

Add attachments
Cancel