Menu ▾ ▴

#663 Setting y limits does not work for regular x fits

v1.1.x
fixed
Erik Hänel
internal (109) fitting (1)
v1.1.3
Bug Fix
2022-03-12
2022-02-11
Erik Hänel
No

Setting a y range for a usual 1D fit does not work although one would expect that it does.

Analysis:

We transform the logics using the new Interval and IntervalSet data classes so that we can handle multiple intervals. Furthermore, we can use these new intervals to restruct also the z intervals.

Implementation:

  • Implementation: Fix was implemented as proposed by the analysis.
  • Revision: [r1068]
  • Implementation test: y ranges were tested manually on a usual fit.

Documentation:

  • [x] ChangesLog updated
  • [x] Code changes commented
  • Documentation articles:
    • [x] corresponding documentation articles updated
    • [ ] new documentation articles created
    • [ ] not needed
  • Language files:
    • [ ] corresponding language files updated
    • [x] not needed

Tests:

Fix was added to the automatic SW tests. No deviations detected.

Related

Commit: [r1068]

Discussion

  • Erik Hänel

    Erik Hänel - 2022-02-11
    • labels: --> internal, fitting
    • status: open --> accepted
     

  • Erik Hänel

    Erik Hänel - 2022-02-11

    Might be even reasonable to enable the z range for 2D-fits as well

     

  • Erik Hänel

    Erik Hänel - 2022-02-12
    • Description has changed:

    Diff:

    --- old
+++ new
@@ -1 +1,23 @@
 Setting a y range for a usual 1D fit does not work although one would expect that it does.
+
+###Analysis:
+(*Describe, what's the issue and which changes have to be made*)
+
+###Implementation:
+* Implementation: (*Describe, what you've changed*) 
+* Revision: [rXXX]
+* Implementation test: (*Describe the type of test, which you performed, and if it was successful*)
+
+###Documentation:
+* [ ] ChangesLog updated
+* [ ] Code changes commented
+* **Documentation articles:**

+    * [ ] corresponding documentation articles updated
+    * [ ] new documentation articles created
+    * [ ] not needed
+* **Language files:**
+    * [ ] corresponding language files updated
+    * [ ] not needed
+
+###Tests:
+(*Describe, which tests you performed and their outcome*)
    • status: accepted --> analyzing
     

  • Erik Hänel

    Erik Hänel - 2022-02-12
    • Description has changed:

    Diff:

    --- old
+++ new
@@ -1,7 +1,7 @@
 Setting a y range for a usual 1D fit does not work although one would expect that it does.

 ###Analysis:
-(*Describe, what's the issue and which changes have to be made*)
+We transform the logics using the new `Interval` and `IntervalSet` data classes so that we can handle multiple intervals. Furthermore, we can use these new intervals to restruct also the `z` intervals.

 ###Implementation:

 * Implementation: (*Describe, what you've changed*)
    • status: analyzing --> implementing
     

  • Erik Hänel

    Erik Hänel - 2022-02-12
    • Description has changed:

    Diff:

    --- old
+++ new
@@ -4,20 +4,20 @@
 We transform the logics using the new `Interval` and `IntervalSet` data classes so that we can handle multiple intervals. Furthermore, we can use these new intervals to restruct also the `z` intervals.

 ###Implementation:
-* Implementation: (*Describe, what you've changed*) 
-* Revision: [rXXX]
-* Implementation test: (*Describe the type of test, which you performed, and if it was successful*)
+* Implementation: Fix was implemented as proposed by the analysis.
+* Revision: [r1068]
+* Implementation test: `y` ranges were tested manually on a usual fit.

 ###Documentation:
-* [ ] ChangesLog updated
-* [ ] Code changes commented
+* [x] ChangesLog updated
+* [x] Code changes commented

 * **Documentation articles:**
-    * [ ] corresponding documentation articles updated
+    * [x] corresponding documentation articles updated
     * [ ] new documentation articles created
     * [ ] not needed
 * **Language files:**
     * [ ] corresponding language files updated
-    * [ ] not needed
+    * [x] not needed

 ###Tests:
 (*Describe, which tests you performed and their outcome*)
     

    Related

    Commit: [r1068]

  • Erik Hänel

    Erik Hänel - 2022-02-12
    • status: implementing --> testing
     

  • Erik Hänel

    Erik Hänel - 2022-03-12
    • Description has changed:

    Diff:

    --- old
+++ new
@@ -20,4 +20,4 @@

     * [x] not needed

 ###Tests:
-(*Describe, which tests you performed and their outcome*)
+Fix was added to the automatic SW tests. No deviations detected.
    • status: testing --> fixed
     

Anonymous
Anonymous

Add attachments
Cancel