Menu ▾ ▴

#649 'assert' evaluates the wrong part of the expression

v1.1.x
fixed
Erik Hänel
None
v1.1.3
Bug Fix
2022-03-10
2022-01-24
Erik Hänel
No

Sometimes, when the expression consists of some embedded string expressions, those are evaluated early by assert although they are not meant to be checked. Might be fixed by adding another flag to the string parser's starting routine to explicitly enable assert for this call (probably only valid in three regions).

Analysis:

Can be implemented as proposed by the analysis.

Implementation:

  • Implementation: Implemented as proposed by the description.
  • Revision: [r1072]
  • Implementation test: The failing expression was re-evaluated without any issues.

Documentation:

  • [x] ChangesLog updated
  • [x] Code changes commented
  • Documentation articles:
    • [ ] corresponding documentation articles updated
    • [ ] new documentation articles created
    • [x] not needed
  • Language files:
    • [ ] corresponding language files updated
    • [x] not needed

Tests:

All tests now run as expected.

Related

Commit: [r1072]

Discussion

  • Erik Hänel

    Erik Hänel - 2022-01-24
    • status: open --> accepted
     

  • Erik Hänel

    Erik Hänel - 2022-02-12
    • Description has changed:

    Diff:

    --- old
+++ new
@@ -1 +1,23 @@
 Sometimes, when the expression consists of some embedded string expressions, those are evaluated early by `assert` although they are not meant to be checked. Might be fixed by adding another flag to the string parser's starting routine to explicitly enable `assert` for this call (probably only valid in three regions).
+
+###Analysis:
+(*Describe, what's the issue and which changes have to be made*)
+
+###Implementation:
+* Implementation: (*Describe, what you've changed*) 
+* Revision: [rXXX]
+* Implementation test: (*Describe the type of test, which you performed, and if it was successful*)
+
+###Documentation:
+* [ ] ChangesLog updated
+* [ ] Code changes commented
+* **Documentation articles:**

+    * [ ] corresponding documentation articles updated
+    * [ ] new documentation articles created
+    * [ ] not needed
+* **Language files:**
+    * [ ] corresponding language files updated
+    * [ ] not needed
+
+###Tests:
+(*Describe, which tests you performed and their outcome*)
    • status: accepted --> analyzing
     

  • Erik Hänel

    Erik Hänel - 2022-02-14
    • Description has changed:

    Diff:

    --- old
+++ new
@@ -1,7 +1,7 @@
 Sometimes, when the expression consists of some embedded string expressions, those are evaluated early by `assert` although they are not meant to be checked. Might be fixed by adding another flag to the string parser's starting routine to explicitly enable `assert` for this call (probably only valid in three regions).

 ###Analysis:
-(*Describe, what's the issue and which changes have to be made*)
+Can be implemented as proposed by the analysis.

 ###Implementation:

 * Implementation: (*Describe, what you've changed*)
    • status: analyzing --> implementing
     

  • Erik Hänel

    Erik Hänel - 2022-02-14
    • Description has changed:

    Diff:

    --- old
+++ new
@@ -4,20 +4,20 @@
 Can be implemented as proposed by the analysis.

 ###Implementation:
-* Implementation: (*Describe, what you've changed*) 
-* Revision: [rXXX]
-* Implementation test: (*Describe the type of test, which you performed, and if it was successful*)
+* Implementation: Implemented as proposed by the description.
+* Revision: [r1072]
+* Implementation test: The failing expression was re-evaluated without any issues.

 ###Documentation:
-* [ ] ChangesLog updated
-* [ ] Code changes commented
+* [x] ChangesLog updated
+* [x] Code changes commented

 * **Documentation articles:**
     * [ ] corresponding documentation articles updated
     * [ ] new documentation articles created
-    * [ ] not needed
+    * [x] not needed
 * **Language files:**
     * [ ] corresponding language files updated
-    * [ ] not needed
+    * [x] not needed

 ###Tests:
 (*Describe, which tests you performed and their outcome*)
    • status: implementing --> testing
     

    Related

    Commit: [r1072]

  • Erik Hänel

    Erik Hänel - 2022-03-10
    • Description has changed:

    Diff:

    --- old
+++ new
@@ -20,4 +20,4 @@

     * [x] not needed

 ###Tests:
-(*Describe, which tests you performed and their outcome*)
+All tests now run as expected.
    • status: testing --> fixed
     

Anonymous
Anonymous

Add attachments
Cancel