Menu ▾ ▴

#648 Dependency graph: clusters are not working correctly

v1.1.x
fixed
Erik Hänel
None
v1.1.3
Bug Fix
2022-03-11
2022-01-24
Erik Hänel
No

If one creates the dependency tree DOT file from the dependency viewer, the clustering of the result does not make sense sometimes: e.g. some clusters are made part of others although they are independent. This might also be related to the fact that "absolute path procedures" where part of the tree.

Analysis:

Has nothing to do with absolute path procedures. The issue is that the cluster depth is not determined correctly, if the first cluster should already be in a nested cluster like analytics~2d~, which is determined as one single cluster instead of two.

Implementation:

  • Implementation: Implemented as indicated by the analysis.
  • Revision: [r1073]
  • Implementation test: The erroneous graph was re-generated without issues.

Documentation:

  • [x] ChangesLog updated
  • [x] Code changes commented
  • Documentation articles:
    • [ ] corresponding documentation articles updated
    • [ ] new documentation articles created
    • [x] not needed
  • Language files:
    • [ ] corresponding language files updated
    • [x] not needed

Tests:

Dependency graphs now show the procedure namespaces as single clusters, which are embedded in their parent namespaces.

Related

Commit: [r1073]

Discussion

  • Erik Hänel

    Erik Hänel - 2022-01-24
    • status: open --> accepted
     

  • Erik Hänel

    Erik Hänel - 2022-02-12
    • Description has changed:

    Diff:

    --- old
+++ new
@@ -1 +1,23 @@
 If one creates the dependency tree DOT file from the dependency viewer, the clustering of the result does not make sense sometimes: e.g. some clusters are made part of others although they are independent. This might also be related to the fact that "absolute path procedures" where part of the tree.
+
+###Analysis:
+(*Describe, what's the issue and which changes have to be made*)
+
+###Implementation:
+* Implementation: (*Describe, what you've changed*) 
+* Revision: [rXXX]
+* Implementation test: (*Describe the type of test, which you performed, and if it was successful*)
+
+###Documentation:
+* [ ] ChangesLog updated
+* [ ] Code changes commented
+* **Documentation articles:**

+    * [ ] corresponding documentation articles updated
+    * [ ] new documentation articles created
+    * [ ] not needed
+* **Language files:**
+    * [ ] corresponding language files updated
+    * [ ] not needed
+
+###Tests:
+(*Describe, which tests you performed and their outcome*)
    • status: accepted --> analyzing
     

  • Erik Hänel

    Erik Hänel - 2022-02-15
    • Description has changed:

    Diff:

    --- old
+++ new
@@ -1,7 +1,7 @@
 If one creates the dependency tree DOT file from the dependency viewer, the clustering of the result does not make sense sometimes: e.g. some clusters are made part of others although they are independent. This might also be related to the fact that "absolute path procedures" where part of the tree.

 ###Analysis:
-(*Describe, what's the issue and which changes have to be made*)
+Has nothing to do with absolute path procedures. The issue is that the cluster depth is not determined correctly, if the first cluster *should* already be in a nested cluster like `analytics~2d~`, which is determined as one single cluster instead of two.

 ###Implementation:

 * Implementation: (*Describe, what you've changed*)
    • status: analyzing --> implementing
     

  • Erik Hänel

    Erik Hänel - 2022-02-15
    • Description has changed:

    Diff:

    --- old
+++ new
@@ -4,20 +4,20 @@
 Has nothing to do with absolute path procedures. The issue is that the cluster depth is not determined correctly, if the first cluster *should* already be in a nested cluster like `analytics~2d~`, which is determined as one single cluster instead of two.

 ###Implementation:
-* Implementation: (*Describe, what you've changed*) 
-* Revision: [rXXX]
-* Implementation test: (*Describe the type of test, which you performed, and if it was successful*)
+* Implementation: Implemented as indicated by the analysis.
+* Revision: [r1073]
+* Implementation test: The erroneous graph was re-generated without issues.

 ###Documentation:
-* [ ] ChangesLog updated
-* [ ] Code changes commented
+* [x] ChangesLog updated
+* [x] Code changes commented

 * **Documentation articles:**
     * [ ] corresponding documentation articles updated
     * [ ] new documentation articles created
-    * [ ] not needed
+    * [x] not needed
 * **Language files:**
     * [ ] corresponding language files updated
-    * [ ] not needed
+    * [x] not needed

 ###Tests:
 (*Describe, which tests you performed and their outcome*)
    • status: implementing --> testing
     

    Related

    Commit: [r1073]

  • Erik Hänel

    Erik Hänel - 2022-03-11
    • Description has changed:

    Diff:

    --- old
+++ new
@@ -20,4 +20,4 @@

     * [x] not needed

 ###Tests:
-(*Describe, which tests you performed and their outcome*)
+Dependency graphs now show the procedure namespaces as single clusters, which are embedded in their parent namespaces.
    • status: testing --> fixed
     

Anonymous
Anonymous

Add attachments
Cancel