Menu ▾ ▴

#577 'dialog' type 'filedialog' needs a file mask feature

v1.1.x
closed
Erik Hänel
None
v1.1.3
Change Request
2021-07-16
2021-05-05
Erik Hänel
No

The dialog command's filedialog type needs the possibility to select one or a set of file masks to propose the correct file types to the user. This can be done like this:

dialog "PATH", "FILEMASKS" -set type=filedialog [...]

Analysis:

Needs some adaptions in the corresponding command function in the kernel and in the GUI function used for displaying the dialog.

Implementation:

  • Implementation: Implemented as proposed by the analysis.
  • Revision: [r868]
  • Implementation test: A file dialog was opened with one, two and three strings passed as expression to the dialog command.

Documentation:

  • [x] ChangesLog updated
  • [x] Code changes commented
  • Documentation articles:
    • [x] corresponding documentation articles updated
    • [ ] new documentation articles created
    • [ ] not needed
  • Language files:
    • [ ] corresponding language files updated
    • [x] not needed

Tests:

Added a fix with [r917] resolving a regression. Change now works as intended.

Related

Commit: [r868]
Commit: [r917]

Discussion

  • Erik Hänel

    Erik Hänel - 2021-05-05
    • status: open --> accepted
     

  • Erik Hänel

    Erik Hänel - 2021-05-05
    • Description has changed:

    Diff:

    --- old
+++ new
@@ -1,3 +1,25 @@
 The `dialog` command's `filedialog` type needs the possibility to select one or a set of file masks to propose the correct file types to the user. This can be done like this:

     dialog "PATH", "FILEMASKS" -set type=filedialog [...]
+
+###Analysis:
+(*Describe, what's the issue and which changes have to be made*)
+
+###Implementation:
+* Implementation: (*Describe, what you've changed*) 
+* Revision: [rXXX]
+* Implementation test: (*Describe the type of test, which you performed, and if it was successful*)
+
+###Documentation:
+* [ ] ChangesLog updated
+* [ ] Code changes commented
+* **Documentation articles:**

+    * [ ] corresponding documentation articles updated
+    * [ ] new documentation articles created
+    * [ ] not needed
+* **Language files:**
+    * [ ] corresponding language files updated
+    * [ ] not needed
+
+###Tests:
+(*Describe, which tests you performed and their outcome*)
    • status: accepted --> analyzing
     

  • Erik Hänel

    Erik Hänel - 2021-05-05
    • Description has changed:

    Diff:

    --- old
+++ new
@@ -3,7 +3,7 @@
     dialog "PATH", "FILEMASKS" -set type=filedialog [...]

 ###Analysis:
-(*Describe, what's the issue and which changes have to be made*)
+Needs some adaptions in the corresponding command function in the kernel and in the GUI function used for displaying the dialog.

 ###Implementation:

 * Implementation: (*Describe, what you've changed*)
    • status: analyzing --> implementing
     

  • Erik Hänel

    Erik Hänel - 2021-05-05
    • Description has changed:

    Diff:

    --- old
+++ new
@@ -6,20 +6,20 @@
 Needs some adaptions in the corresponding command function in the kernel and in the GUI function used for displaying the dialog.

 ###Implementation:
-* Implementation: (*Describe, what you've changed*) 
-* Revision: [rXXX]
-* Implementation test: (*Describe the type of test, which you performed, and if it was successful*)
+* Implementation: Implemented as proposed by the analysis.
+* Revision: [r868]
+* Implementation test: A file dialog was opened with one, two and three strings passed as expression to the `dialog` command.

 ###Documentation:
-* [ ] ChangesLog updated
-* [ ] Code changes commented
+* [x] ChangesLog updated
+* [x] Code changes commented

 * **Documentation articles:**
-    * [ ] corresponding documentation articles updated
+    * [x] corresponding documentation articles updated
     * [ ] new documentation articles created
     * [ ] not needed
 * **Language files:**
     * [ ] corresponding language files updated
-    * [ ] not needed
+    * [x] not needed

 ###Tests:
 (*Describe, which tests you performed and their outcome*)
    • status: implementing --> testing
     

    Related

    Commit: [r868]

  • Erik Hänel

    Erik Hänel - 2021-07-16
    • Description has changed:

    Diff:

    --- old
+++ new
@@ -22,4 +22,4 @@

     * [x] not needed

 ###Tests:
-(*Describe, which tests you performed and their outcome*)
+Added a fix with [r917] resolving a regression. Change now works as intended.
    • status: testing --> closed
     

    Related

    Commit: [r917]

Anonymous
Anonymous

Add attachments
Cancel





MongoDB Logo MongoDB