Menu ▾ ▴

#481 Open package creator independent from the active file

v1.1.x
closed
Erik Hänel
None
v1.1.2
Change Request
2019-12-08
2019-09-26
Erik Hänel
No

Open the package creator independent on the current opened file. The user shall then select the procedures he or she wants to include in the package.

Analysis:

This change is simple: remove the file type checking in NumeReWindow::OnCreatePackage(). The file type checking should only be used to include the current opened file if it is a procedure file.

Implementation:

  • Implementation: The change was implemented as proposed by the analysis.
  • Revision: [r659]
  • Implementation test: The package creator was opened from procedure files and from non-procedure files.

Documentation:

  • [x] ChangesLog updated
  • [x] Code changes commented
  • Documentation articles:
    • [ ] corresponding documentation articles updated
    • [ ] new documentation articles created
    • [x] not needed
  • Language files:
    • [ ] corresponding language files updated
    • [x] not needed

Tests:

This change was tested manually. No deviation detected.

Related

Commit: [r659]

Discussion

  • Erik Hänel

    Erik Hänel - 2019-09-26
    • status: open --> accepted
     

  • Erik Hänel

    Erik Hänel - 2019-11-02
    • Description has changed:

    Diff:

    --- old
+++ new
@@ -1 +1,23 @@
 Open the package creator independent on the current opened file. The user shall then select the procedures he or she wants to include in the package.
+
+###Analysis:
+(*Describe, what's the issue and which changes have to be made*)
+
+###Implementation:
+* Implementation: (*Describe, what you've changed*) 
+* Revision: [rXXX]
+* Implementation test: (*Describe the type of test, which you performed, and if it was successful*)
+
+###Documentation:
+* [ ] ChangesLog updated
+* [ ] Code changes commented
+* **Documentation articles:**

+    * [ ] corresponding documentation articles updated
+    * [ ] new documentation articles created
+    * [ ] not needed
+* **Language files:**
+    * [ ] corresponding language files updated
+    * [ ] not needed
+
+###Tests:
+(*Describe, which tests you performed and their outcome*)
    • status: accepted --> analyzing
     

  • Erik Hänel

    Erik Hänel - 2019-11-02
    • Description has changed:

    Diff:

    --- old
+++ new
@@ -1,7 +1,7 @@
 Open the package creator independent on the current opened file. The user shall then select the procedures he or she wants to include in the package.

 ###Analysis:
-(*Describe, what's the issue and which changes have to be made*)
+This change is simple: remove the file type checking in `NumeReWindow::OnCreatePackage()`. The file type checking should only be used to include the current opened file if it is a procedure file.

 ###Implementation:

 * Implementation: (*Describe, what you've changed*)
    • status: analyzing --> implementing
     

  • Erik Hänel

    Erik Hänel - 2019-11-02
    • Description has changed:

    Diff:

    --- old
+++ new
@@ -4,20 +4,20 @@
 This change is simple: remove the file type checking in `NumeReWindow::OnCreatePackage()`. The file type checking should only be used to include the current opened file if it is a procedure file.

 ###Implementation:
-* Implementation: (*Describe, what you've changed*) 
-* Revision: [rXXX]
-* Implementation test: (*Describe the type of test, which you performed, and if it was successful*)
+* Implementation: The change was implemented as proposed by the analysis.
+* Revision: [r659]
+* Implementation test: The package creator was opened from procedure files and from non-procedure files.

 ###Documentation:
-* [ ] ChangesLog updated
-* [ ] Code changes commented
+* [x] ChangesLog updated
+* [x] Code changes commented

 * **Documentation articles:**
     * [ ] corresponding documentation articles updated
     * [ ] new documentation articles created
-    * [ ] not needed
+    * [x] not needed
 * **Language files:**
     * [ ] corresponding language files updated
-    * [ ] not needed
+    * [x] not needed

 ###Tests:
 (*Describe, which tests you performed and their outcome*)
    • status: implementing --> testing
     

    Related

    Commit: [r659]

  • Erik Hänel

    Erik Hänel - 2019-12-08
    • Description has changed:

    Diff:

    --- old
+++ new
@@ -20,4 +20,4 @@

     * [x] not needed

 ###Tests:
-(*Describe, which tests you performed and their outcome*)
+This change was tested manually. No deviation detected.
    • status: testing --> closed
     

Anonymous
Anonymous

Add attachments
Cancel





MongoDB Logo MongoDB