Menu ▾ ▴

#479 Segmentation Fault in Dependency Viewer

v1.1.x
fixed
Erik Hänel
critical (96)
v1.1.2
Bug Fix
2019-08-21
2019-07-08
Erik Hänel
No

If the dependency viewer is opened on a procedure file, which does not contain a single naming procedure, a segmentation fault occurs.

Analysis:

The issue is that the algorithm won't detect the main procedure of the current file. This main procedure is however needed to construct the dependency tree in the dialog. Fix it, by displaying an error message, if the main procedure is not found in the file.

Implementation:

  • Implementation: The fix was applied as proposed by the analysis.
  • Revision: [r601]
  • Implementation test: Dependencies of a file lacking a main procedure were calculated. The error message appeared as expected.

Documentation:

  • [x] ChangesLog updated
  • [x] Code changes commented
  • Documentation articles:
    • [ ] corresponding documentation articles updated
    • [ ] new documentation articles created
    • [x] not needed
  • Language files:
    • [ ] corresponding language files updated
    • [x] not needed

Tests:

This fix was tested manually. No deviation occured.

Related

Commit: [r601]

Discussion

  • Erik Hänel

    Erik Hänel - 2019-07-08
    • status: open --> accepted
     

  • Erik Hänel

    Erik Hänel - 2019-07-08
    • Description has changed:

    Diff:

    --- old
+++ new
@@ -1 +1,23 @@
 If the dependency viewer is opened on a procedure file, which does not contain a single naming procedure, a segmentation fault occurs.
+
+###Analysis:
+(*Describe, what's the issue and which changes have to be made*)
+
+###Implementation:
+* Implementation: (*Describe, what you've changed*) 
+* Revision: [rXXX]
+* Implementation test: (*Describe the type of test, which you performed, and if it was successful*)
+
+###Documentation:
+* [ ] ChangesLog updated
+* [ ] Code changes commented
+* **Documentation articles:**

+    * [ ] corresponding documentation articles updated
+    * [ ] new documentation articles created
+    * [ ] not needed
+* **Language files:**
+    * [ ] corresponding language files updated
+    * [ ] not needed
+
+###Tests:
+(*Describe, which tests you performed and their outcome*)
    • status: accepted --> analyzing
     

  • Erik Hänel

    Erik Hänel - 2019-07-15
    • Description has changed:

    Diff:

    --- old
+++ new
@@ -1,7 +1,7 @@
 If the dependency viewer is opened on a procedure file, which does not contain a single naming procedure, a segmentation fault occurs.

 ###Analysis:
-(*Describe, what's the issue and which changes have to be made*)
+The issue is that the algorithm won't detect the main procedure of the current file. This main procedure is however needed to construct the dependency tree in the dialog. Fix it, by displaying an error message, if the main procedure is not found in the file.

 ###Implementation:

 * Implementation: (*Describe, what you've changed*)
    • status: analyzing --> implementing
     

  • Erik Hänel

    Erik Hänel - 2019-07-15
    • Description has changed:

    Diff:

    --- old
+++ new
@@ -4,20 +4,20 @@
 The issue is that the algorithm won't detect the main procedure of the current file. This main procedure is however needed to construct the dependency tree in the dialog. Fix it, by displaying an error message, if the main procedure is not found in the file.

 ###Implementation:
-* Implementation: (*Describe, what you've changed*) 
-* Revision: [rXXX]
-* Implementation test: (*Describe the type of test, which you performed, and if it was successful*)
+* Implementation: The fix was applied as proposed by the analysis.
+* Revision: [r601]
+* Implementation test: Dependencies of a file lacking a main procedure were calculated. The error message appeared as expected.

 ###Documentation:
-* [ ] ChangesLog updated
-* [ ] Code changes commented
+* [x] ChangesLog updated
+* [x] Code changes commented

 * **Documentation articles:**
     * [ ] corresponding documentation articles updated
     * [ ] new documentation articles created
-    * [ ] not needed
+    * [x] not needed
 * **Language files:**
     * [ ] corresponding language files updated
-    * [ ] not needed
+    * [x] not needed

 ###Tests:
 (*Describe, which tests you performed and their outcome*)
    • status: implementing --> testing
     

    Related

    Commit: [r601]

  • Erik Hänel

    Erik Hänel - 2019-08-21
    • Description has changed:

    Diff:

    --- old
+++ new
@@ -20,4 +20,4 @@

     * [x] not needed

 ###Tests:
-(*Describe, which tests you performed and their outcome*)
+This fix was tested manually. No deviation occured.
    • status: testing --> fixed
     

Anonymous
Anonymous

Add attachments
Cancel





MongoDB Logo MongoDB