Menu ▾ ▴

#462 Improve the internal architecture of 'Define'

v1.1.x
closed
Erik Hänel
None
v1.1.2
Change Request
2019-08-19
2019-03-18
Erik Hänel
No

The internal architecture of the Define class is full of legacy code. Improve it to match the current implementation standard.

Analysis:

To achieve a better implementation, one has to separate the single definition and the container functionality. In the future, the Define object will be the container, the single definition will be implemented as new object called FunctionDefinition.

Implementation:

  • Implementation: The change was implemented as proposed by the analysis.
  • Revision: [r511]
  • Implementation test: The software test for function definitions was used to validate the implementation.

Documentation:

  • ChangesLog: updated
  • Comments: Code was commented sufficiently
  • Documentation articles: not needed
  • Language files: not needed

Tests:

Change was tested in productive environment. No deviations detected.

Related

Commit: [r511]
Tickets: #410

Discussion

  • Erik Hänel

    Erik Hänel - 2019-03-18
    • status: open --> accepted
     

  • Erik Hänel

    Erik Hänel - 2019-03-18
    • Description has changed:

    Diff:

    --- old
+++ new
@@ -1 +1,18 @@
 The internal architecture of the `Define` class is full of legacy code. Improve it to match the current implementation standard.
+
+###Analysis:
+(*Describe, what's the issue and which changes have to be made*)
+
+###Implementation:
+* Implementation: (*Describe, what you've changed*) 
+* Revision: [rXXX]
+* Implementation test: (*Describe the type of test, which you performed, and if it was successful*)
+
+###Documentation:
+* ChangesLog: (*Have you updated the changes log?*)
+* Comments: (*Have you written comments in the code, which describe your change?*)
+* Documentation articles: (*Have you updated the documentation articles?*)
+* Language files: (*Have you updated the language files?*)
+
+###Tests:
+(*Describe, which tests you performed and their outcome*)
    • status: accepted --> analyzing
     

  • Erik Hänel

    Erik Hänel - 2019-03-23
    • Description has changed:

    Diff:

    --- old
+++ new
@@ -1,7 +1,7 @@
 The internal architecture of the `Define` class is full of legacy code. Improve it to match the current implementation standard.

 ###Analysis:
-(*Describe, what's the issue and which changes have to be made*)
+To achieve a better implementation, one has to separate the single definition and the container functionality. In the future, the `Define` object will be the container, the single definition will be implemented as new object called `FunctionDefinition`.

 ###Implementation:

 * Implementation: (*Describe, what you've changed*)
    • status: analyzing --> implementing
     

  • Erik Hänel

    Erik Hänel - 2019-03-23
    • Description has changed:

    Diff:

    --- old
+++ new
@@ -4,15 +4,15 @@
 To achieve a better implementation, one has to separate the single definition and the container functionality. In the future, the `Define` object will be the container, the single definition will be implemented as new object called `FunctionDefinition`.

 ###Implementation:
-* Implementation: (*Describe, what you've changed*) 
-* Revision: [rXXX]
-* Implementation test: (*Describe the type of test, which you performed, and if it was successful*)
+* Implementation: The change was implemented as proposed by the analysis.
+* Revision: [r511]
+* Implementation test: The software test for function definitions was used to validate the implementation.

 ###Documentation:
-* ChangesLog: (*Have you updated the changes log?*)
-* Comments: (*Have you written comments in the code, which describe your change?*)
-* Documentation articles: (*Have you updated the documentation articles?*)
-* Language files: (*Have you updated the language files?*)
+* ChangesLog: updated
+* Comments: Code was commented sufficiently
+* Documentation articles: not needed
+* Language files: not needed

 ###Tests:
 (*Describe, which tests you performed and their outcome*)
    • status: implementing --> testing
     

    Related

    Commit: [r511]

  • Erik Hänel

    Erik Hänel - 2019-08-19
    • Description has changed:

    Diff:

    --- old
+++ new
@@ -15,4 +15,4 @@

 * Language files: not needed

 ###Tests:
-(*Describe, which tests you performed and their outcome*)
+Change was tested in productive environment. No deviations detected.
    • status: testing --> closed
     

Anonymous
Anonymous

Add attachments
Cancel





MongoDB Logo MongoDB