Menu ▾ ▴

#444 Code abstrahizer issues

v1.1.x
fixed
Erik Hänel
None
v1.1.1
Bug Fix
2019-08-21
2019-02-13
Erik Hänel
No

If one uses the code abstrahizer to extract MATLAB code segments, the detection, whether a variable is modified or not, fails if the variable is a structure containing MATLAB standard function names as its fields. Additionally the return values of the current functions scope are not used correctly either.

Analysis:

The first issue is quite straighforward to fix. The second issue needs some MATLAB-specific enhancements.

Implementation:

  • Implementation: The fix was implemented as proposed by the analysis. To solve the second issue, input argument list and return list are now considered separately
  • Revision: [r473]
  • Implementation test: MATLAB code with occured deviations were abstrahized without any deviation.

Documentation:

  • ChangesLog: updated
  • Comments: New functions were commented sufficiently
  • Documentation articles: Not needed
  • Language files: Not needed

Tests:

This fix was tested manually. No deviation detected.

Related

Commit: [r473]

Discussion

  • Erik Hänel

    Erik Hänel - 2019-02-13
    • status: open --> accepted
     

  • Erik Hänel

    Erik Hänel - 2019-02-14
    • Description has changed:

    Diff:

    --- old
+++ new
@@ -1 +1,18 @@
 If one uses the code abstrahizer to extract MATLAB code segments, the detection, whether a variable is modified or not, fails if the variable is a structure containing MATLAB standard function names as its fields. Additionally the return values of the current functions scope are not used correctly either.
+
+###Analysis:
+(*Describe, what's the issue and which changes have to be made*)
+
+###Implementation:
+* Implementation: (*Describe, what you've changed*) 
+* Revision: [rXXX]
+* Implementation test: (*Describe the type of test, which you performed, and if it was successful*)
+
+###Documentation:
+* ChangesLog: (*Have you updated the changes log?*)
+* Comments: (*Have you written comments in the code, which describe your change?*)
+* Documentation articles: (*Have you updated the documentation articles?*)
+* Language files: (*Have you updated the language files?*)
+
+###Tests:
+(*Describe, which tests you performed and their outcome*)
    • status: accepted --> analyzing
     

  • Erik Hänel

    Erik Hänel - 2019-02-20
    • Description has changed:

    Diff:

    --- old
+++ new
@@ -1,7 +1,7 @@
 If one uses the code abstrahizer to extract MATLAB code segments, the detection, whether a variable is modified or not, fails if the variable is a structure containing MATLAB standard function names as its fields. Additionally the return values of the current functions scope are not used correctly either.

 ###Analysis:
-(*Describe, what's the issue and which changes have to be made*)
+The first issue is quite straighforward to fix. The second issue needs some MATLAB-specific enhancements.

 ###Implementation:

 * Implementation: (*Describe, what you've changed*)
    • status: analyzing --> implementing
     

  • Erik Hänel

    Erik Hänel - 2019-02-20
    • Description has changed:

    Diff:

    --- old
+++ new
@@ -4,15 +4,15 @@
 The first issue is quite straighforward to fix. The second issue needs some MATLAB-specific enhancements.

 ###Implementation:
-* Implementation: (*Describe, what you've changed*) 
-* Revision: [rXXX]
-* Implementation test: (*Describe the type of test, which you performed, and if it was successful*)
+* Implementation: The fix was implemented as proposed by the analysis. To solve the second issue, input argument list and return list are now considered separately
+* Revision: [r473]
+* Implementation test: MATLAB code with occured deviations were abstrahized without any deviation.

 ###Documentation:
-* ChangesLog: (*Have you updated the changes log?*)
-* Comments: (*Have you written comments in the code, which describe your change?*)
-* Documentation articles: (*Have you updated the documentation articles?*)
-* Language files: (*Have you updated the language files?*)
+* ChangesLog: updated
+* Comments: New functions were commented sufficiently
+* Documentation articles: Not needed
+* Language files: Not needed

 ###Tests:
 (*Describe, which tests you performed and their outcome*)
    • status: implementing --> testing
     

    Related

    Commit: [r473]

  • Erik Hänel

    Erik Hänel - 2019-08-21
    • Description has changed:

    Diff:

    --- old
+++ new
@@ -15,4 +15,4 @@

 * Language files: Not needed

 ###Tests:
-(*Describe, which tests you performed and their outcome*)
+This fix was tested manually. No deviation detected.
    • status: testing --> fixed
     

Anonymous
Anonymous

Add attachments
Cancel





MongoDB Logo MongoDB