Menu ▾ ▴

#438 Smart Brackets

v1.1.x
fixed
Erik Hänel
None
v1.1.1
Bug Fix
2019-08-19
2019-02-08
Rudolf Brausemann
No

Wenn man Klammern öffnet, dann erzeugt man auch sofort schließende Klammern; diese sind aber nicht durch die selbe Klammer überschreibbar, man muss dann immer eine Stelle weiterrücken/klicken, um im Code weiterzumachen.

Analysis:

This feature may be implemented as part of the NumeReEditor::OnKeyDn() member function. This function already contains the logic for surrounding a text selection with parentheses and quotation marks. It should be possible to add a logic for skipping the closing parenthesis, if the closing one is already available. This can be done by using the BraceMatch() member function for parentheses and current style for quotation marks.

Implementation:

  • Implementation: The fix was processed as proposed by the analysis
  • Revision: [r463]
  • Implementation test: Parentheses and quotation marks were typed in many combinations withut any deviation

Documentation:

  • ChangesLog: Updated
  • Comments: The modified function was commented sufficiently
  • Documentation articles: Not needed
  • Language files: Not needed

Tests:

Bug fix was tested in productive environment. No deviations detected.

Related

Commit: [r463]

Discussion

  • Erik Hänel

    Erik Hänel - 2019-02-08
    • status: open --> accepted
     

  • Erik Hänel

    Erik Hänel - 2019-02-09
    • Description has changed:

    Diff:

    --- old
+++ new
@@ -1 +1,18 @@
 Wenn man Klammern öffnet, dann erzeugt man auch sofort schließende Klammern; diese sind aber nicht durch die selbe Klammer überschreibbar, man muss dann immer eine Stelle weiterrücken/klicken, um im Code weiterzumachen.
+
+###Analysis:
+(*Describe, what's the issue and which changes have to be made*)
+
+###Implementation:
+* Implementation: (*Describe, what you've changed*) 
+* Revision: [rXXX]
+* Implementation test: (*Describe the type of test, which you performed, and if it was successful*)
+
+###Documentation:
+* ChangesLog: (*Have you updated the changes log?*)
+* Comments: (*Have you written comments in the code, which describe your change?*)
+* Documentation articles: (*Have you updated the documentation articles?*)
+* Language files: (*Have you updated the language files?*)
+
+###Tests:
+(*Describe, which tests you performed and their outcome*)
    • status: accepted --> analyzing
     

  • Erik Hänel

    Erik Hänel - 2019-02-10
    • Description has changed:

    Diff:

    --- old
+++ new
@@ -1,7 +1,7 @@
 Wenn man Klammern öffnet, dann erzeugt man auch sofort schließende Klammern; diese sind aber nicht durch die selbe Klammer überschreibbar, man muss dann immer eine Stelle weiterrücken/klicken, um im Code weiterzumachen.

 ###Analysis:
-(*Describe, what's the issue and which changes have to be made*)
+This feature may be implemented as part of the `NumeReEditor::OnKeyDn()` member function. This function already contains the logic for surrounding a text selection with parentheses and quotation marks. It should be possible to add a logic for skipping the closing parenthesis, if the closing one is already available. This can be done by using the `BraceMatch()` member function for parentheses and current style for quotation marks.

 ###Implementation:

 * Implementation: (*Describe, what you've changed*)
    • status: analyzing --> implementing
     

  • Erik Hänel

    Erik Hänel - 2019-02-11
    • Description has changed:

    Diff:

    --- old
+++ new
@@ -4,15 +4,15 @@
 This feature may be implemented as part of the `NumeReEditor::OnKeyDn()` member function. This function already contains the logic for surrounding a text selection with parentheses and quotation marks. It should be possible to add a logic for skipping the closing parenthesis, if the closing one is already available. This can be done by using the `BraceMatch()` member function for parentheses and current style for quotation marks.

 ###Implementation:
-* Implementation: (*Describe, what you've changed*) 
-* Revision: [rXXX]
-* Implementation test: (*Describe the type of test, which you performed, and if it was successful*)
+* Implementation: The fix was processed as proposed by the analysis
+* Revision: [r463]
+* Implementation test: Parentheses and quotation marks were typed in many combinations withut any deviation

 ###Documentation:
-* ChangesLog: (*Have you updated the changes log?*)
-* Comments: (*Have you written comments in the code, which describe your change?*)
-* Documentation articles: (*Have you updated the documentation articles?*)
-* Language files: (*Have you updated the language files?*)
+* ChangesLog: Updated
+* Comments: The modified function was commented sufficiently
+* Documentation articles: Not needed
+* Language files: Not needed

 ###Tests:
 (*Describe, which tests you performed and their outcome*)
    • status: implementing --> testing
     

    Related

    Commit: [r463]

  • Erik Hänel

    Erik Hänel - 2019-08-19
    • Description has changed:

    Diff:

    --- old
+++ new
@@ -15,4 +15,4 @@

 * Language files: Not needed

 ###Tests:
-(*Describe, which tests you performed and their outcome*)
+Bug fix was tested in productive environment. No deviations detected.
    • status: testing --> fixed
     

Anonymous
Anonymous

Add attachments
Cancel





MongoDB Logo MongoDB