Menu

#320 Fix various cross platform compiler issues

3.x Stable
open
nobody
None
5
2 days ago
7 days ago
Jason
No

This has been a few years of small patches I've found for various compiler specific issues.

1 Attachments

Discussion

  • Anders

    Anders - 5 days ago
    1. Why remove the any from searchparsestring?
    2. In util.cpp you change to snprintf, which compiler was complaining about this?
    3. What breaks without 'LANGUAGE LANG_ENGLISH, SUBLANG_ENGLISH_US'?
    4. What was the problem with the 7zip maxMode thing?
     
  • Jason

    Jason - 2 days ago
    1. Latest clang on mac (M1 mac with Tahoe) warns that adding a bool does nothing.
    2. Again, latest clang on mac.
    3. It was either VS 7.0 or VS7.1 rc.exe that throws an error when the input is empty.
    4. Oh, that's just cosmetic, latest clang on mac complains about misleading indentation.
     
    👍
    1
    • Anders

      Anders - 2 days ago
      1. The compiler is wrong. " " + !(FALSE) gives you "" (empty string). Will have to work around that in another way.
      2. Hopefully it does not break VC6, I will try to check.
       

Log in to post a comment.

MongoDB Logo MongoDB