[NSIS-Bugs] [ nsis-Patches-1539701 ] DirShow back!!! uncomplete checks but working!

[SourceForge.net <no...@so...>]

Patches item #1539701, was opened at 2006-08-14 00:28
Message generated for change (Comment added) made by czi
You can respond by visiting: 
https://sourceforge.net/tracker/?func=detail&atid=373087&aid=1539701&group_id=22049

Please note that this message will contain a full copy of the comment thread,
including the initial issue submission, for this request,
not just the latest update.
Category: NSIS
Group: Unstable
Status: Open
Resolution: None
Priority: 5
Submitted By: David Weiss (czi)
Assigned to: Amir Szekely (kichik)
Summary: DirShow back!!! uncomplete checks but working!

Initial Comment:
DirShow is back!

you wanted it (ToDo list), here it is.

works only as pageex command for the dirpage, and
validation functions are limited.

directory page will not show up, if:
- "DirShow hide" is used AND .onVerifyInstDir succeeds
AND the directory is a valid path specification EVEN if
there is not enough disk space available

directory page will show up if:
- DirShow is not used (old behaviour)
- "DirShow show" is used
- "DirShow hide" is used AND directory is set to a root
(e.g. C:\), EVEN if AllowRootDirInstall true is set



i did not fix the rootdir thing yet, though i might be
able to fix this one (and i'll try).

i also could not manage to get it checking for free
disk space without copying too much code from the
DirProc function.

kichik, could you look after that?

i guess it requires some refactoring...




attached patch includes source files only, no
documentation or MUI support yet.

----------------------------------------------------------------------

>Comment By: David Weiss (czi)
Date: 2006-08-28 10:55

Message:
Logged In: YES 
user_id=970495

Then just remove it from the TODO list and i'm happy with it.

----------------------------------------------------------------------

Comment By: Amir Szekely (kichik)
Date: 2006-08-25 19:44

Message:
Logged In: YES 
user_id=584402

All the more reason to remove this annoyingly awkward option
called DirShow, in my opinion. It was nice when the
installer handled the pages itself, but now it's just
irrelevant.

----------------------------------------------------------------------

Comment By: David Weiss (czi)
Date: 2006-08-20 00:56

Message:
Logged In: YES 
user_id=970495

you're right, this is a real problem.

but i think i could solve that in another way:

the button text in nsis 2.0 is set at build time, yep, but
also on runtime, according to the language used.

now, when the language setting is able to change the text,
the rest of the installer should not have problems to do the
same.

this is, where i would hack into. DirShow should alter the
text in the same manner as the language thing does. and a t
the same time.

then, if the user wants to overwrite the text with something
else, he still can do.

the problem here is, that we can't really check the install
dir anywhere else than directly before the directorypage.

so we can't alter the page before the directorypage, because
this page could still alter $INSTDIR in the leave function,
and the check should be done after that (in the pre function
of dirpage).

as a summary, i don't see why we should have problems
altering the button texts on any page, because this could be
done without limiting user's abilities.
the real problem is, that we can't alter the text, because
at the time the page shows up, we do not know yet, if the
$INSTDIR path is valid, because we can't check that, because
it may not be the final setting.

----------------------------------------------------------------------

Comment By: Amir Szekely (kichik)
Date: 2006-08-19 12:31

Message:
Logged In: YES 
user_id=584402

The old DirShow only checked for the validity of the path
itself and not for the free space. However, the old
implementation automatically changed the text of the
buttons. If the directory page was the last page before the
instfiles page, it would set the `Next` button text to
`Install` for the previous page. That's the actual problem
with the new pages system and DirShow. The new pages system
takes care of the button texts in build process and not on
runtime.

This automatic approach of DirShow is a bit problematic with
the new semi-manual pages system. You can't just take the
button text of the next page or the last page as that page
might have special handling for the button text.

The best solution I could think of is creating a new thing
called page-sets. Before exposing this to the user, it can
be used to create two possible routes of pages for the
installer. One with the directory page and one without it.
Though it could pose a bit of a problem when deciding to
switch between the two because you can't really tell where
exactly to. Maybe a tree would be better in this case.

----------------------------------------------------------------------

You can respond by visiting: 
https://sourceforge.net/tracker/?func=detail&atid=373087&aid=1539701&group_id=22049