[NSIS-Bugs] [ nsis-Bugs-1543323 ] Very strange - code not being compiled

[SourceForge.net <no...@so...>]

Bugs item #1543323, was opened at 2006-08-19 23:59
Message generated for change (Comment added) made by dandaman32
You can respond by visiting: 
https://sourceforge.net/tracker/?func=detail&atid=373085&aid=1543323&group_id=22049

Please note that this message will contain a full copy of the comment thread,
including the initial issue submission, for this request,
not just the latest update.
Category: Scripting
Group: None
Status: Closed
Resolution: Invalid
Priority: 8
Submitted By: dandaman32 (dandaman32)
Assigned to: Amir Szekely (kichik)
Summary: Very strange - code not being compiled

Initial Comment:
Hey, I'm working on an installer for a client, and I
think I've found something truly baffling. Take a look
at this compiler output:

Command line: 
"C:\Program Files\NSIS\makensis.exe"  /NOTIFYHWND
721932  "D:\PHP_Installer\PHP-IIS\Setup.nsi"

*** SNIP ***

Section: "-copyFiles"
CreateDirectory: "$INSTDIR"
!include: "res\FileList.nsh"
*** SNIP ***
!include: closed: "res\FileList.nsh"
ReadRegStr $0
HKLM\System\CurrentControlSet\Control\Session
Manager\Environment\Path
Push: $0
Push: $INSTDIR\php4
Call "StrStr"
Pop: $0
StrCmp "$0" "" equal=0, nonequal=NoAdd
DetailPrint: "Adding $INSTDIR\php4 to PATH"
Push: $INSTDIR\php4
Call "AddToPath" ; LOOK RIGHT HERE! THIS FUNCTION IS
BEING CALLED
WriteRegStr:
HKLM\System\CurrentControlSet\Control\Session
Manager\Environment\PHPRC=$INSTDIR\php4
SendMessage:
(timeout=5000)(0xFFFF,0x001A,0,STR:Environment)
WriteUninstaller: "$INSTDIR\uninst.exe"
WriteRegStr:
HKLM\Software\Microsoft\Windows\CurrentVersion\Uninstall\PHP-IIS\DisplayName=$(^Name)
WriteRegStr:
HKLM\Software\Microsoft\Windows\CurrentVersion\Uninstall\PHP-IIS\UninstallString=$INSTDIR\uninst.exe
WriteRegStr:
HKLM\Software\Microsoft\Windows\CurrentVersion\Uninstall\PHP-IIS\DisplayIcon=$INSTDIR\StartWiz.exe
WriteRegDWORD:
HKLM\Software\Microsoft\Windows\CurrentVersion\Uninstall\PHP-IIS\NoModify=1
WriteRegDWORD:
HKLM\Software\Microsoft\Windows\CurrentVersion\Uninstall\PHP-IIS\NoRepair=1
CreateDirectory: "$SMPROGRAMS\$(^Name)"
CreateShortCut: "$SMPROGRAMS\$(^Name)\Get
Support.lnk"->"iexplore.exe http://www.iis-aid.com" 
icon:,0, showmode=0x0, hotkey=0x0, comment=
CreateShortCut: "$SMPROGRAMS\$(^Name)\PHP
Info.lnk"->"$INSTDIR\php4\phpinfo.exe"  icon:,0,
showmode=0x0, hotkey=0x0, comment=
CreateShortCut: "$SMPROGRAMS\$(^Name)\Integration
Assistant.lnk"->"$INSTDIR\startwiz.exe"  icon:,0,
showmode=0x0, hotkey=0x0, comment=
CreateShortCut: "$SMPROGRAMS\$(^Name)\Uninstall
$(^Name).lnk"->"$INSTDIR\uninst.exe"  icon:,0,
showmode=0x0, hotkey=0x0, comment=
SectionEnd

*** SNIP ***

Processed 1 file, writing output:
Adding plug-ins initializing function... Done!
warning: uninstall function "un.RemoveFromPath" not
referenced - zeroing code (0-66) out

warning: uninstall function "un.RemoveFromEnvVar" not
referenced - zeroing code (66-138) out

warning: install function "AddToEnvVar" not referenced
- zeroing code (55-104) out

Processing pages... Done!
Removing unused resources... Done!
Generating language tables... Done!
Generating uninstaller... Done!

Output:
"D:\PHP_Installer\PHP-IIS\IIS-Aid_PHP_Installer-Beta_1.exe"
Install: 13 pages (832 bytes), 2 sections (1 required)
(2096 bytes), 1610 instructions (45080 bytes), 735
strings (16898 bytes), 1 language table (394 bytes).
Uninstall: 6 pages (384 bytes), 
1 section (1048 bytes), 1082 instructions (30296
bytes), 628 strings (18228 bytes), 1 language table
(342 bytes).
Datablock optimizer saved 131839 bytes (~0.6%).

Using zlib compression.

EXE header size:               55808 / 34816 bytes
Install code:                  65788 / 65784 bytes
Install data:               21112739 / 21244586 bytes
Uninstall code+data:          544756 / 544748 bytes
CRC (0x7CDB6BB5):                  4 / 4 bytes

Total size:                 21779095 / 21889938 bytes
(99.5%)

3 warnings:
  uninstall function "un.RemoveFromPath" not referenced
- zeroing code (0-66) out

  uninstall function "un.RemoveFromEnvVar" not
referenced - zeroing code (66-138) out

  install function "AddToEnvVar" not referenced -
zeroing code (55-104) out <--- WHAT IS GOING ON HERE!?

any ideas, guys? My client is compiling the installer
using MakeNSIS 2.18, and he has the ExperienceUI
version 1.11pre installed. My client has given me
permission to provide the script to NSIS administrators
(KiCHiK, Ximon, eccles, Joost, and sunjammer)

-dandaman32

----------------------------------------------------------------------

>Comment By: dandaman32 (dandaman32)
Date: 2006-08-26 04:01

Message:
Logged In: YES 
user_id=1178091

Ugh. Now I feel really stupid :-]

Turns out the code seemed to work on his desktop computer
but not his laptop, he e-mailed me the day after I submitted
this bug and told me it was his fault. Sheesh, some people
just don't know how to confirm a bug...don't tell him I said
that ;-)

-dandaman32

----------------------------------------------------------------------

Comment By: Amir Szekely (kichik)
Date: 2006-08-25 06:00

Message:
Logged In: YES 
user_id=584402

AddToEnvVar is not AddToPath. Your script calls AddToPath
and the compiler complains about AddToEnvVar not being
referenced.

----------------------------------------------------------------------

Comment By: dandaman32 (dandaman32)
Date: 2006-08-20 00:03

Message:
Logged In: YES 
user_id=1178091

Ohyeah, forgot - this code worked in earlier builds of the
installer.

-dandaman32

----------------------------------------------------------------------

You can respond by visiting: 
https://sourceforge.net/tracker/?func=detail&atid=373085&aid=1543323&group_id=22049