Menu
▾
▴
[NSIS-Bugs] [ nsis-Patches-1414825 ] clearer error messages for Icon command
|
From: SourceForge.net <no...@so...> - 2006-01-27 16:46:14
|
Patches item #1414825, was opened at 2006-01-25 19:08 Message generated for change (Comment added) made by czi You can respond by visiting: https://sourceforge.net/tracker/?func=detail&atid=373087&aid=1414825&group_id=22049 Please note that this message will contain a full copy of the comment thread, including the initial issue submission, for this request, not just the latest update. Category: NSIS Group: Stable Status: Closed Resolution: Rejected Priority: 5 Submitted By: David Weiss (czi) Assigned to: Amir Szekely (kichik) Summary: clearer error messages for Icon command Initial Comment: this patch adds some error messages tpo the Icon command, that help clarify problems with icons and debugging wrong icon files. ---------------------------------------------------------------------- >Comment By: David Weiss (czi) Date: 2006-01-27 17:46 Message: Logged In: YES user_id=970495 yep, thats fine. it was just one possibility of many to make things more clear :) ---------------------------------------------------------------------- Comment By: Amir Szekely (kichik) Date: 2006-01-27 16:59 Message: Logged In: YES user_id=584402 Thanks for the patch. I ended up adding exceptions instead of more return values and also modified generate_uninstall_icon_data to do the same. The code already had exceptions for bad_malloc and it makes the code look nicer in script.cpp. ---------------------------------------------------------------------- You can respond by visiting: https://sourceforge.net/tracker/?func=detail&atid=373087&aid=1414825&group_id=22049 |