[NSIS-Bugs] [ nsis-Bugs-1068019 ] bug in ResourceEditor.cpp

[SourceForge.net <no...@so...>]

Bugs item #1068019, was opened at 2004-11-17 14:56
Message generated for change (Tracker Item Submitted) made by Item Submitter
You can respond by visiting: 
https://sourceforge.net/tracker/?func=detail&atid=373085&aid=1068019&group_id=22049

Category: None
Group: None
Status: Open
Resolution: None
Priority: 5
Submitted By: Juergen Hofmann (shiphrah)
Assigned to: Nobody/Anonymous (nobody)
Summary: bug in ResourceEditor.cpp

Initial Comment:
ResourceEditor.cpp, Revision: 1.23

I believe that 

void CResourceEditor::WriteRsrcSec(BYTE* pbRsrcSec)

contains a bug at:

#ifdef _WIN32
    // MultiByteToWideChar return value includes the
null char, so -1
    iLen = MultiByteToWideChar(CP_ACP, 0, szName, iLen,
szwName, iLen) - 1;
#else

The MultiByteToWideChar does NOT include the null char
(at least not on my system). This causes resource names
to be truncated with one character. Although this does
not seem to cause problems in NSIS, it causes problems
with usage of executables that contain other resources.

----------------------------------------------------------------------

You can respond by visiting: 
https://sourceforge.net/tracker/?func=detail&atid=373085&aid=1068019&group_id=22049