Menu
▾
▴
[NSIS-Bugs] [ nsis-Bugs-3475080 ] adding to system PATH environment variable can *nuke* it
|
From: SourceForge.net <no...@so...> - 2012-05-25 19:40:52
|
Bugs item #3475080, was opened at 2012-01-17 12:06 Message generated for change (Comment added) made by benbaker You can respond by visiting: https://sourceforge.net/tracker/?func=detail&atid=373085&aid=3475080&group_id=22049 Please note that this message will contain a full copy of the comment thread, including the initial issue submission, for this request, not just the latest update. Category: None Group: None Status: Open Resolution: None Priority: 5 Private: No Submitted By: Roger Pack (rogerdpack) Assigned to: Nobody/Anonymous (nobody) Summary: adding to system PATH environment variable can *nuke* it Initial Comment: Hello. I noticed when installing this: http://sourceforge.net/projects/opencvlibrary/files/opencv-win/2.1/OpenCV-2.1.0-win32-vs2008.exe/download ("add to system path for all users") that it *deleted* my system PATH environment variable, and replaced it with (only) C:\OpenCV2.1\bin which is obviously bad. I realize this is probably caused by some other problem but just noting it since it surprised me. Cheers! -roger- ---------------------------------------------------------------------- Comment By: Ben Baker (benbaker) Date: 2012-05-25 12:40 Message: This is a common bug with NSIS installers because if you write code that queries a variable that is longer than the NSIS string limit (typically 1024), you get back an empty string. The code then thinks that the variable is empty, appends to it, then overwrites the current value -> nuking it. NSIS could fix this bug by removing the limit on string lengths so that the NSIS API could return the actual value for the PATH and the users NSIS script could append to it and write out the new value. ---------------------------------------------------------------------- Comment By: Jim Michaels (jmichae3) Date: 2012-04-19 22:27 Message: I am going to vote for this bug. even windows XP's PATH and cmd shell length has been boosted to 8189 characters on later versions of windows and on XP 8190 characters. I would use something much longer to be safe in case microsoft decides to change things again. how about using c++'s string, or using a 16384-character string? ---------------------------------------------------------------------- Comment By: Anders (anders_k) Date: 2012-01-19 16:13 Message: NSIS does have a string limit that makes it problematic to manipulate the system wide path environment variable but your bug is probably is some 3rd party code or a snippet from the wiki and not something we can really do anything about on this tracker... ---------------------------------------------------------------------- You can respond by visiting: https://sourceforge.net/tracker/?func=detail&atid=373085&aid=3475080&group_id=22049 |
