[NSIS-Bugs] [ nsis-Patches-1982084 ] wrong UI behaviour on size texts (VS2005)

[SourceForge.net <no...@so...>]

Patches item #1982084, was opened at 2008-06-02 16:02
Message generated for change (Comment added) made by kichik
You can respond by visiting: 
https://sourceforge.net/tracker/?func=detail&atid=373087&aid=1982084&group_id=22049

Please note that this message will contain a full copy of the comment thread,
including the initial issue submission, for this request,
not just the latest update.
Category: NSIS
Group: None
Status: Open
Resolution: None
Priority: 5
Private: No
Submitted By: Nobody/Anonymous (nobody)
Assigned to: Amir Szekely (kichik)
Summary: wrong UI behaviour on size texts (VS2005)

Initial Comment:
in Ui.c

line 
  wsprintf(
    GetNSISString(g_tmp, prefix) + mystrlen(g_tmp),
has undefined behaviour under C specifications.

mystrlen could be called before GetNSISString, and this happens when NSIS is compiled under Visual Studio 2005 with full optimizations.

so I suggest the following change :
  GetNSISString(g_tmp, prefix);
  wsprintf(
    g_tmp + mystrlen(g_tmp),


Wizou


----------------------------------------------------------------------

>Comment By: Amir Szekely (kichik)
Date: 2008-07-25 15:43

Message:
Logged In: YES 
user_id=584402
Originator: NO

The first of many things I've already tried.

----------------------------------------------------------------------

Comment By: Nobody/Anonymous (nobody)
Date: 2008-07-21 11:25

Message:
Logged In: NO 

try this:
char *tmp = GetNSISString(g_tmp, prefix);
wsprintf(
tmp + mystrlen(tmp),


----------------------------------------------------------------------

Comment By: Amir Szekely (kichik)
Date: 2008-06-12 23:27

Message:
Logged In: YES 
user_id=584402
Originator: NO

That change adds quite a few bytes. I'll have to think of another fix for
it, or if nothing else, I can #ifdef it.

----------------------------------------------------------------------

You can respond by visiting: 
https://sourceforge.net/tracker/?func=detail&atid=373087&aid=1982084&group_id=22049