Menu
▾
▴
[NSIS-Bugs] [ nsis-Feature Requests-1949260 ] add detection for Win2008 to WinVer header
|
From: SourceForge.net <no...@so...> - 2008-05-11 00:42:53
|
Feature Requests item #1949260, was opened at 2008-04-23 01:42 Message generated for change (Comment added) made by anders_k You can respond by visiting: https://sourceforge.net/tracker/?func=detail&atid=373088&aid=1949260&group_id=22049 Please note that this message will contain a full copy of the comment thread, including the initial issue submission, for this request, not just the latest update. Category: General Group: 2.0 Series Status: Open Priority: 5 Private: No Submitted By: chef_koch (chef_koch) Assigned to: Nobody/Anonymous (nobody) Summary: add detection for Win2008 to WinVer header Initial Comment: How about adding the detection for Windows 2008 to the header file: "WinVer.nsh". ---------------------------------------------------------------------- Comment By: Anders (anders_k) Date: 2008-05-11 02:43 Message: Logged In: YES user_id=872912 Originator: NO I came up with something, but I don't have a server OS to test with (Only did limited testing on xp with the compatibility tab) http://pastebin.ca/1014249 I added tests for 2000Srv and XP64 aswell as 2008 The new version constants are in the following format: 0xMmmS, where M=major, m=minor and S is 1 on server on 0 on workstation platforms ---------------------------------------------------------------------- Comment By: Amir Szekely (kichik) Date: 2008-05-10 11:47 Message: Logged In: YES user_id=584402 Originator: NO But 6.0.6001 is Vista's version as well. We have no choice but to move on to GetVersionEx and friends. You want to take care of that Anders? ---------------------------------------------------------------------- Comment By: Anders (anders_k) Date: 2008-05-10 03:33 Message: Logged In: YES user_id=872912 Originator: NO The kernel is the same as Vista SP1 (And I'm guessing the major usermode dlls like kernel32 and user32 aswell) So, maybe 6.0.6001 should just be known as Win2008, WinVer.nsh does not detect other service packs does it? If you need something for display purposes, you can call GetVersionEx yourself no? ---------------------------------------------------------------------- Comment By: Amir Szekely (kichik) Date: 2008-04-23 15:51 Message: Logged In: YES user_id=584402 Originator: NO That article is what I also saw and according to it you can't differentiate between 2008 and Vista SP1 with the current GetVersion method. I'd like WinVer.nsh to detect at least the version. If it means calling GetVersionEx, so be it. ---------------------------------------------------------------------- Comment By: chef_koch (chef_koch) Date: 2008-04-23 14:20 Message: Logged In: YES user_id=1200683 Originator: YES forgot the link, sorry ;) http://www.codeguru.com/cpp/w-p/system/systeminformation/article.php/c8973/ ---------------------------------------------------------------------- Comment By: chef_koch (chef_koch) Date: 2008-04-23 14:20 Message: Logged In: YES user_id=1200683 Originator: YES i am not able to test it on win08 but i found this document, here? What do you think about adding better detections to this header file which is distributed by default in nsis installation? Or should i add the more complex detection to my own header file, to keep the official one slim, clean and simple? ---------------------------------------------------------------------- Comment By: Amir Szekely (kichik) Date: 2008-04-23 11:35 Message: Logged In: YES user_id=584402 Originator: NO When you run winver.exe on 2008 does it say Version 6.0 or something else? ---------------------------------------------------------------------- You can respond by visiting: https://sourceforge.net/tracker/?func=detail&atid=373088&aid=1949260&group_id=22049 |