Menu
▾
▴
[NSIS-Bugs] [ nsis-Bugs-1864507 ] Dangerous example of MUI_STARTMENU_GETFOLDER macro
|
From: SourceForge.net <no...@so...> - 2008-01-05 14:59:34
|
Bugs item #1864507, was opened at 2008-01-05 15:59 Message generated for change (Tracker Item Submitted) made by Item Submitter You can respond by visiting: https://sourceforge.net/tracker/?func=detail&atid=373085&aid=1864507&group_id=22049 Please note that this message will contain a full copy of the comment thread, including the initial issue submission, for this request, not just the latest update. Category: Documentation Group: 2.0 Series Status: Open Resolution: None Priority: 5 Private: No Submitted By: Sebastian Pipping (hartwork) Assigned to: Nobody/Anonymous (nobody) Summary: Dangerous example of MUI_STARTMENU_GETFOLDER macro Initial Comment: NSIS version 2.34 The Modern UI 1/2 documentation contains a quite dangerous example of using the MUI_STARTMENU_GETFOLDER macro: !insertmacro MUI_STARTMENU_GETFOLDER page_id $R0 Delete "$SMPROGRAMS\$R0\Your Shortcut.lnk" People copy-pasting this can actually delete the whole start menu if "Do not create shortcuts" was chosen, because that will return the empty string in the uninstaller. I strongly suggest to replace the example with !insertmacro MUI_STARTMENU_GETFOLDER page_id $R0 StrCmp $R0 "" NO_SHORTCUTS Delete "$SMPROGRAMS\$R0\Your Shortcut.lnk" NO_SHORTCUTS: Thank you! ---------------------------------------------------------------------- You can respond by visiting: https://sourceforge.net/tracker/?func=detail&atid=373085&aid=1864507&group_id=22049 |