#856 Missing iconv dependency in LibraryLocal in 2.42

[Thomas Kho]

I get the error below when building on OS X complaining about undefined iconv symbols. Attached patch adds linking to iconv and fixes the problem. This is on NSIS 2.42 building from source without precompiled bits.

> scons SKIPUTILS="NSIS Menu" PREFIX_DEST=/Users/thomaskho/Desktop/nsis
...
g++ -o build/release/Library/LibraryLocal/LibraryLocal -m32 -s build/release/Library/LibraryLocal/LibraryLocal.o build/release/Library/LibraryLocal/ResourceEditor.o build/release/Library/LibraryLocal/util.o build/release/Library/LibraryLocal/winchar.o
ld warning: option -s is obsolete and being ignored
Undefined symbols:
"_iconv_open", referenced from:
MultiByteToWideChar(unsigned int, unsigned int, char const*, int, unsigned short*, int)in util.o
IsValidCodePage(unsigned int)in util.o
WideCharToMultiByte(unsigned int, unsigned int, unsigned short const*, int, char*, int, char const*, int*)in util.o
"_iconv", referenced from:
MultiByteToWideChar(unsigned int, unsigned int, char const*, int, unsigned short*, int)in util.o
WideCharToMultiByte(unsigned int, unsigned int, unsigned short const*, int, char*, int, char const*, int*)in util.o
"_iconv_close", referenced from:
MultiByteToWideChar(unsigned int, unsigned int, char const*, int, unsigned short*, int)in util.o
MultiByteToWideChar(unsigned int, unsigned int, char const*, int, unsigned short*, int)in util.o
IsValidCodePage(unsigned int)in util.o
WideCharToMultiByte(unsigned int, unsigned int, unsigned short const*, int, char*, int, char const*, int*)in util.o
WideCharToMultiByte(unsigned int, unsigned int, unsigned short const*, int, char*, int, char const*, int*)in util.o
ld: symbol(s) not found
collect2: ld returned 1 exit status
scons: *** [build/release/Library/LibraryLocal/LibraryLocal] Error 1
scons: building terminated because of errors.

[Thomas Kho]

patch to link LibraryLocal to iconv

[Amir Szekely]

Thanks, fixed.