notion-devel

[Notion-devel] Patches! Some debug printing and better focuslist update behavior

[Dima K. <no...@di...>]

Hi.

I made a few changes, and the updated tree is the master branch at

 https://github.com/dkogan/notion/

This tree contains

1. The license update sent previously

2. Functions to debug-print a region hierarchy, manager hiearchy and
focuslist contents

3. Enhanced behavior to update the focus list. After this patch windows
are added to the focus list only after a delay. This makes it such that
windows that were focused for a very short time are not added to the
focus list. As a result, the user can now search for a window by quickly
cycling through some windows. Once the user finds the window they seek,
they can go back to the window they were previously working on using any
key binding that consults the focus list. Prior to this patch, those
bindings would go to the previously-focused window, even though it was
one that was only quickly visited en route to what the user was looking
for. After this patch, the previous window on the focus list is the one
they were working on.

This patch required the separation of the variables containing the
"focus list" and the "currently focused region". I've been running this
for a few days now, and things appear to work as they should.

Re: [Notion-devel] Patches! Some debug printing and better focuslistupdate behaviorr

[Dima K. <no...@di...>]

no...@di... writes:

> I made a few changes, and the updated tree is the master branch at
>
>  https://github.com/dkogan/notion/

I found another bug, and made another patch, which now also appears in
that tree.

This is a bug in query_lua where consecutive completions would never
happen if mod_query.autoshowcompl was enabled.

To trigger the bug, invoke binding that calls

mod_query.query_lua()

Then type "ionco" and press TAB. mod_query then completes this to "ioncore.". At
this point the completion should happen again, and the various
methods/properties of ioncore should be displayed. This does not happen.
Pressing TAB again doesn't work either. One actually has to delete the "." and
re-type it.

This was happening because the second completion was being blocked. I THINK this
was trying to prevent a timer re-entrancy. However everything is synchronous, so
this couldn't happen anyway.


I've been running this for a bit, and it seems to work well. Does
somebody have more detail about why those locks were there? Is it unsafe
to remove them?

dima

Re: [Notion-devel] Patches! Some debug printing and betterfocuslistupdate behaviorrr

[Dima K. <no...@di...>]

I made some small fixes to previously-mentioned patches in the tree, and
I added another feature I wanted:

Activity alerts can now be displayed on EVERY screen, if an option to do
this is given. I just started using notion with multiple screens, and
I was missing this functionality. This appears to work so far, but I
just made this change, so not a lot of testing happened yet. I'll fix
issues when/if they come up. Once again, the tree is at

 https://github.com/dkogan/notion

dima

Re: [Notion-devel] Patches! Some debug printing and better focuslist update behavior

[Dima K. <no...@di...>]

ar...@bz... writes:

> 1) License update: I'm still not really sure we can just replace/patch in a
> new license like that. While the new license is GPG-signed, I cannot locate
> the public key Tuomo used to sign the message (key id C004251B), so that's
> kind of useless. OTOH it was his mailinglist and he didn't complain about
> seeing an imposter, so this public record might be sufficient.

I'm pretty sure it's fine. In any case, you can cherry-pick the patches
you like and skip the ones you don't. I'll keep rebasing my tree to play
nice with upstream.


> 2) For debug logging, please use the ioncore/log.h instead of fprintf'ing
> to stderr directly (feel free to add categories as you wish). Currently the
> loglevels are hard-coded in ioncore/log.c, but that of course should be
> made configurable later.

Ah yes. I didn't see that before. I updated my tree to use those. Thanks.

Re: [Notion-devel] Patches! Some debug printing and better focuslist update behavior

[Philipp H. <ph...@ph...>]

Hey there,

back in 2011 I sent a message with instructions for veryfing the gpg
signature on the license change to this list [1] and these
instructions still seem to work. At least I'm still able to download
the key using gpg --recv-keys with "keyserver hkp://keys.gnupg.net" in
my gpg.conf.

Cheers,
Philipp

[1] http://sourceforge.net/mailarchive/message.php?msg_id=28377299

Re: [Notion-devel] Patches! Some debug printing and better focuslist update behavior

[Arnout E. <ar...@bz...>]

Hi Dima,

Thanks for your patches.

1) License update: I'm still not really sure we can just replace/patch in a
new license like that. While the new license is GPG-signed, I cannot locate
the public key Tuomo used to sign the message (key id C004251B), so that's
kind of useless. OTOH it was his mailinglist and he didn't complain about
seeing an imposter, so this public record might be sufficient.

2) For debug logging, please use the ioncore/log.h instead of fprintf'ing
to stderr directly (feel free to add categories as you wish). Currently the
loglevels are hard-coded in ioncore/log.c, but that of course should be
made configurable later.

3) That sounds useful, I should look into that.


Arnout


On Tue, Jan 21, 2014 at 7:10 AM, Dima Kogan <no...@di...>wrote:

> Hi.
>
> I made a few changes, and the updated tree is the master branch at
>
>  https://github.com/dkogan/notion/
>
> This tree contains
>
> 1. The license update sent previously
>
> 2. Functions to debug-print a region hierarchy, manager hiearchy and
> focuslist contents
>
> 3. Enhanced behavior to update the focus list. After this patch windows
> are added to the focus list only after a delay. This makes it such that
> windows that were focused for a very short time are not added to the
> focus list. As a result, the user can now search for a window by quickly
> cycling through some windows. Once the user finds the window they seek,
> they can go back to the window they were previously working on using any
> key binding that consults the focus list. Prior to this patch, those
> bindings would go to the previously-focused window, even though it was
> one that was only quickly visited en route to what the user was looking
> for. After this patch, the previous window on the focus list is the one
> they were working on.
>
> This patch required the separation of the variables containing the
> "focus list" and the "currently focused region". I've been running this
> for a few days now, and things appear to work as they should.
>
>
> ------------------------------------------------------------------------------
> CenturyLink Cloud: The Leader in Enterprise Cloud Services.
> Learn Why More Businesses Are Choosing CenturyLink Cloud For
> Critical Workloads, Development Environments & Everything In Between.
> Get a Quote or Start a Free Trial Today.
>
> http://pubads.g.doubleclick.net/gampad/clk?id=119420431&iu=/4140/ostg.clktrk
> _______________________________________________
> Notion-devel mailing list
> Not...@li...
> https://lists.sourceforge.net/lists/listinfo/notion-devel
>