notion-devel

[Notion-devel] Issues While Developing A Package For Fedora

[Jeff B. <jef...@gm...>]

Hi folks,

I am working on packaging Notion for Fedora, and a few things have come up.

The RPM lint tool complains about cs/man1/notion.1.gz and 
fi/man1/notion.1.gz not being UTF-8. Are there any objections to my 
converting them to UTF-8 via iconv? The files seemed to convert okay 
when compared with tkdiff, however, I don't speak/read either language 
so I thought I'd ask.

It looks like the address for the Free Software Foundation is out of 
date in libtu/rb.c and libtu/rb.h. These files list the address as:
     59 Temple Place, Suite 330, Boston, MA 02111-1307 USA
however the current address is:
     51 Franklin Street, Fifth Floor, Boston, MA 02110-1301 USA
The RPM linter checks for and complains about this. I don't know if it 
can be hand-waved away during the review process or not... (my first 
time packaging)

contrib/statusbar isn't part of the default install?

There are several different licenses used in contrib/, but to me they 
all appear to be compatible with GPLv3. Any objections to listing the 
license as GPLv3? Fedora does allow the option of specifying multiple 
licenses, but I'd like to avoid that if possible.

Also, a few bits of errata came up. These don't necessarily need to be 
addressed but I thought I'd at least mention them.

The ChangeLog is apparently supposed to be autogenerated, however that 
does not appear to be happening. Currently, the file only contains the 
statement "(The ChangeLog will be generated by release scripts from svn 
logs)". Any interest in correcting this or removing it? RELNOTES appears 
to be ... out of date. Any interest in correcting or removing this one 
also? As it is, I'm just copying these as is, along with LICENSE and README.

There does not appear to be a man page for notionflux. Any plans for 
adding one in the future? Also, it appears that the documentation isn't 
part of the source snapshot? At least not notion-3-2013030200-src.tar.bz2.

Any and all help would be greatly appreciated. Thanks in advance!

Regards,
Jeff

-- 
Jeff Backus
jef...@gm...
http://github.com/jsbackus

[Notion-devel] Fwd: Issues While Developing A Package For Fedora

[Arnout E. <no...@bz...>]

On Fri, Nov 1, 2013 at 10:47 PM, Jeff Backus <jef...@gm...> wrote:

> The RPM lint tool complains about cs/man1/notion.1.gz and
> fi/man1/notion.1.gz not being UTF-8. Are there any objections to my
> converting them to UTF-8 via iconv?
>

I wouldn't have objections to you converting them - of course ideally that
change also makes it 'upstream' to our own git.


> It looks like the address for the Free Software Foundation is out of
> date in libtu/rb.c and libtu/rb.h. These files list the address as:
>      59 Temple Place, Suite 330, Boston, MA 02111-1307 USA
> however the current address is:
>      51 Franklin Street, Fifth Floor, Boston, MA 02110-1301 USA
> The RPM linter checks for and complains about this. I don't know if it
> can be hand-waved away during the review process or not... (my first
> time packaging)
>

Idem


> contrib/statusbar isn't part of the default install?
>

Hmm i think it *should* be there.


> There are several different licenses used in contrib/, but to me they
> all appear to be compatible with GPLv3. Any objections to listing the
> license as GPLv3? Fedora does allow the option of specifying multiple
> licenses, but I'd like to avoid that if possible.
>

Not sure what Fedora's policies are on this front. For Debian we made a
fairly exhaustive listing of all licenses of all different parts of the
package, so you could either go for GPLv3 (if compatible) or make use of
that. Up to you.


> Also, a few bits of errata came up. These don't necessarily need to be
> addressed but I thought I'd at least mention them.
>
> The ChangeLog is apparently supposed to be autogenerated, however that
> does not appear to be happening. Currently, the file only contains the
> statement "(The ChangeLog will be generated by release scripts from svn
> logs)". Any interest in correcting this or removing it? RELNOTES appears
> to be ... out of date. Any interest in correcting or removing this one
> also? As it is, I'm just copying these as is, along with LICENSE and
> README.
>

Yeah we should find a better solution there.


> There does not appear to be a man page for notionflux. Any plans for
> adding one in the future?


Would be good to add one


> Also, it appears that the documentation isn't
> part of the source snapshot? At least not notion-3-2013030200-src.tar.bz2.
>

Makes sense to add that I suppose, yeah.


Kind regards,

Arnout

Re: [Notion-devel] Issues While Developing A Package For Fedora

[Jeff B. <jef...@gm...>]

2013-11-02  Arnout Engelen  <arn...@bz...>

	use $(CC) rather than 'gcc'
	https://sourceforge.net/p/notion/bugs/62/

	Removed old stuff from system-inc.mk
	Thanks to Olof Johansson for noticing

2013-09-16  Arnout Engelen  <arn...@bz...>

	Fix segfault when logging not finding a font

2013-09-10  Arnout Engelen  <arn...@bz...>

	Improved lua version detection (thanks Nikolay Orlyuk and Justin Lebar!)
	https://sourceforge.net/p/notion/bugs/64/

	Slightly better logging for font loading

2013-08-05  Arnout Engelen  <arn...@bz...>

	Compile warning

	Be more forgiving when XCreateFontSet creates a fontset with missing charsets
	Especially utf-8 locales list unreasonable amounts of charsets as requirements.
	When a font can be found that satisfies some, but not all of them, we just use
	the font and write a warning into the logging. A user who really cares about
	all those charsets can fix his configuration himself.

2013-07-28  Arnout Engelen  <arn...@bz...>

	In use_mb mode, use a more reasonable default/fallback font.
	'fixed' does not exist for the multibyte font searching methods, and it does
	not make sense to have this be a compile-time option.

2013-07-22  Arnout Engelen  <arn...@bz...>

	Correct error message when no fontset was found

2013-07-21  Arnout Engelen  <arn...@bz...>

	Add target to quickly compile a snapshot version

	Only build the 'travis' github branch on Travis

	Also make C99_SOURCE overridable

2013-07-21  Olof Johansson  <ol...@et...>

	build: Use more overrideable system-autodetect.mk

[Notion-devel] Fwd: Issues While Developing A Package For Fedora

[Arnout E. <no...@bz...>]

On Sun, Nov 3, 2013 at 12:02 AM, Jeff Backus <jef...@gm...> wrote:

>
> On 11/02/2013 12:02 PM, Arnout Engelen wrote:
>
>   I wouldn't have objections to you converting them - of course ideally
> that change also makes it 'upstream' to our own git.
>
> Will do! I'll send the patches your way once I have things buttoned down.
>
>   Idem
>
> Forgive me, but I assume Idem = "I don't think it matters"? If so, then
> yes, I agree. I'll put together a patch anyway since it's a simple fix.
> I'll send it your way if you want it, but I don't think it's a big deal.
>

Ah, sorry - with 'idem' i meant 'my previous statement also goes for this'
- in other words, I'd indeed like to apply this change to the notion git.


>
>> contrib/statusbar isn't part of the default install?
>>
>
>  Hmm i think it *should* be there.
>
> Good thing I asked. :) It is missing from contrib/install-scripts.sh.
> Maybe this script is old/out of date? Should we replace it with a Makefile?
>

I don't think I use it - in any case added statusbar directory to the
script.


>
>
>  Not sure what Fedora's policies are on this front. For Debian we made a
> fairly exhaustive listing of all licenses of all different parts of the
> package, so you could either go for GPLv3 (if compatible) or make use of
> that. Up to you.
>
> I'll take a look at the Debian packages. I'll also tweak my install
> locations to better mimic those paths. Speaking of which, looks like the
> packages haven't been updated since July 3rd, 2012?
>

That's probably accurate


>
>
>
>> The ChangeLog is apparently supposed to be autogenerated, however that
>> does not appear to be happening. Currently, the file only contains the
>> statement "(The ChangeLog will be generated by release scripts from svn
>> logs)". Any interest in correcting this or removing it? RELNOTES appears
>> to be ... out of date. Any interest in correcting or removing this one
>> also? As it is, I'm just copying these as is, along with LICENSE and
>> README.
>>
>
>  Yeah we should find a better solution there.
>
> Maybe this?
>
> http://git.savannah.gnu.org/gitweb/?p=gnulib.git;a=blob_plain;f=build-aux/gitlog-to-changelog
>
> I've attached the first 50 lines of output generated from the main notion
> repo.
>

That looks pretty good.


Kind regards,

Arnout

Re: [Notion-devel] Fwd: Issues While Developing A Package For Fedora

[Jeff B. <jef...@gm...>]

On 11/03/2013 05:55 AM, Arnout Engelen wrote:
>
> Ah, sorry - with 'idem' i meant 'my previous statement also goes for 
> this' - in other words, I'd indeed like to apply this change to the 
> notion git.
Great! The patches are available both in the GitHub repo as well as from 
DropBox:
https://www.dropbox.com/sh/n1icl72l63dy9tr/guxGW9Ll8t

Patches were generated on notion-3-2013030200.tar.bz2 with the latest 
repo version of notion-doc. You may need to play with the -p option to 
patch if you don't want to rebuild the whole tree. The patches are 
independent. They are as follows:

  * notion-3.2013030200.p00-man-utf8.patch - Modifies man/Makefile to
    run iconv after mkman.lua. Shouldn't cause Make to stop if it can't
    find iconv. There's probably a better way to handle this...
  * notion-3.2013030200.p01-fsf_addr.patch - Fixes the address for the
    FSF in libtu/rb.h and libtu/rb.c
  * notion-doc-3.2013030200.p02-css_newline.patch - rpmlint complained
    about doc/notion.css using <CRLF> instead of <LF>. I generated a
    patch for consistency and so that the build wouldn't fail if the
    builder doesn't have dos2unix installed. You should be able to just
    run dos2unix instead of installing the patch.
  * notion-3.2013030200.p03-ChangeLog_update.patch - Patch to replace
    the contents of ChangeLog with the output of gitlog-to-changelog. I
    only generated a changelog for the primary repo at the proper
    release tag.

>
> I don't think I use it - in any case added statusbar directory to the 
> script.
Yeah, I generally do a 'cp */*.lua /etc/notion' but I figured I should 
avoid such shortcuts. :) I've added statusbar to the contrib subpackage.

So I've successfully generated RPMs that pass the linter with only two 
outstanding issues:

  * No manpage for notionflux (I don't believe that this will cause much
    friction)
  * Non-binary files in /usr/lib. Not sure if this is an issue or not. I
    followed the file structure from the Debian notion-devel package.
    Any chance these can go in /usr/share/notion?
      o /usr/lib/notion/build/libs.mk
      o /usr/lib/notion/config.h
      o /usr/lib/notion/install-sh
      o /usr/lib/notion/libextl/libextl-makeports

Full RPM file lists are available at the above DropBox location under 
RPM_File_Lists. I've verified the RPMs build and install under Fedora 18 
(what I'm on), Fedora 19, and Fedora 20 (in beta). I've verified that 
the packages work fine under Fedora 18. Hopefully that will be sufficient.

Next step is to try to make the fool thing official.

Regards,
Jeff

-- 
Jeff Backus
jef...@gm...
http://github.com/jsbackus