Re: [Notion-devel] [Notion-general] Notion 4

[Dima K. <no...@di...>]

Hi. Notes inline.


> On Mon, Sep 30, 2019 at 6:17 AM Dima Kogan <no...@di...> wrote:
>
>> After installing the new package on my box, I could run notion, but it
>> started up in some odd state where the look was different, and most (but
>> not all) of my bindings didn't work anymore. No error messages.

I debugged this. Not related to the update, it turns out. Never mind!



Arnout Engelen <no...@bz...> writes:

> I changed the style loading code to auto-detect 'based_on' based on prefix.
> The PR is at https://github.com/raboof/notion/pull/197 . Could you have a look
> if that does the trick for you?

I just tested it. Better. Previously (the latest notion from a few days
ago) I needed to do this in my look to make things look mostly as before:

  de.defstyle("frame-tiled", {
      based_on = "frame",
      spacing = 0,
  })

  de.defstyle("frame-tiled-alt", {
      based_on = "frame",
      spacing = 0,
  })

  de.defstyle("tab-frame-tiled", {
      based_on = "tab",
      spacing = 0,
  })

With that update (auto-detecting 'based_on' from the prefix), I can omit
the based_on stuff, and get similar results. I still see some
look-related issues that aren't fixed with any based_on invocation I
tried:

1. In my look the empty-pane color used to be black, but now it's gray.
   Empty panes come up when I create a new workspace with
   ioncore.create_ws(_). This is also the filler color used to cover
   empty space if a window doesn't completely fill a tab. Do you know
   what style thing controls this?

2. I think the margin between the top of the tab bar and the top of the
   screen has increased by a few pixels. Do you know what controls this?

3. Menus that pop up with mod_menu are now using a different font. For
   instance, the main menu: mod_menu.menu(_, _sub, 'mainmenu',
   {big=true}). Do you know where this font is set? It also looks weird
   on my machine, and I suspect my box doesn't actually HAVE this font.
   So there could also be a packaging issue I need to look at. Any way
   to tell what font it's trying to use?

Thanks!