Re: [Notion-devel] [Notion-general] Notion 4

[Arnout E. <no...@bz...>]

On Wed, Oct 2, 2019 at 6:58 PM Dima Kogan <no...@di...> wrote:
> Arnout Engelen <no...@bz...> writes:
> > On Mon, Sep 30, 2019 at 6:17 AM Dima Kogan <no...@di...> wrote:
> >> The title bars
> >> should be yellow, but in the new notion they're coming up black.
> >
> > Perhaps you need to add the 'based_on' fields as documented in the
> > migration notes?
>
> I debugged this. I needed to do two things:
>
> 1. Add a base to the "tab" style, so that it now looks like this:
>
>     de.defstyle("tab", {
>         based_on = "*",
>         ....
>
> 2. Remove the "tab-frame-tiled" style, or add a base to it. I had this:
>
>     de.defstyle("tab-frame-tiled", {
>         spacing = 0,
>     })
>
>
>   Removing this entirely, or adding
>
>     based_on = "tab"
>
>   gave me the yellow window tabs back. based_on="*" doesn't do it.

Aha. Without looking at the code, it seems ion auto-detected the parent
by looking at the name of the style.

> Is there any way to make this fail in a friendlier way? Could we somehow
> detect that something isn't right, and to throw an error message, at the
> very least?

Hmm, I don't really see how we could detect this, but...

> Or maybe consider reverting the inheritance change?

Unfortunately, the based_on field was removed during the "Ion License" days,
so we cannot just 'revert' this (without re-introducing non-LGPL code). Instead,
I changed the style loading code to auto-detect 'based_on' based on prefix.
The PR is at https://github.com/raboof/notion/pull/197 . Could you have a look
if that does the trick for you?

> I suspect that a large number of users are using configurations that
> haven't been touched or thought-about for many years; and it'd be nice
> if stuff kept working.

Yeah - I think we can afford to change some defaults since it's a new major
version, but indeed we shouldn't create arbitrary barriers.


Kind regards,

Arnout