From: Dima K. <no...@di...> - 2019-10-02 16:58:52
|
Arnout Engelen <no...@bz...> writes: > On Mon, Sep 30, 2019 at 6:17 AM Dima Kogan <no...@di...> wrote: > >> After installing the new package on my box, I could run notion, but it >> started up in some odd state where the look was different, and most (but >> not all) of my bindings didn't work anymore. No error messages. > > That's weird. Let me poke at this later... >> As a test I then moved ~/.notion/default-session--0 and restarted >> notion. It came up with the correct keybindings this time, but the look >> was still broken. It is apparently loading the correct .lua file >> defining the look, but it doesn't work anymore. >> Can somebody please see why it's loading incorrectly? The title bars >> should be yellow, but in the new notion they're coming up black. > > Perhaps you need to add the 'based_on' fields as documented in the > migration notes? I debugged this. I needed to do two things: 1. Add a base to the "tab" style, so that it now looks like this: de.defstyle("tab", { based_on = "*", .... 2. Remove the "tab-frame-tiled" style, or add a base to it. I had this: de.defstyle("tab-frame-tiled", { spacing = 0, }) Removing this entirely, or adding based_on = "tab" gave me the yellow window tabs back. based_on="*" doesn't do it. Is there any way to make this fail in a friendlier way? Could we somehow detect that something isn't right, and to throw an error message, at the very least? Or maybe consider reverting the inheritance change? I suspect that a large number of users are using configurations that haven't been touched or thought-about for many years; and it'd be nice if stuff kept working. Thanks! |