Re: [Notion-devel] Some bindmaps were empty, loading ioncore_efbb

[Josef 'J. S. <je...@jo...>]

On Wed, Dec 17, 2014 at 10:04:59AM +0100, Arnout Engelen wrote:
> On Tue, Dec 16, 2014 at 10:38 PM, Josef 'Jeff' Sipek <je...@jo...>
> wrote:
> >
> > > I really want to avoid adding more compile-time switches, things
> > > are too complicated to my taste already.
> > >
> > > a) dropping support for lua5.1
> > > b) not support lua5.2 unless it was compiled with LUA_COMPAT_ALL
> >
> > It does look like Lua 5.1 is getting a bit old, while
> > Lua 5.2 is three years old.  (It looks like 5.3 will be released in the
> > near
> > future.) http://www.lua.org/versions.html
> >
> > Hrm, I'm thinking more about this and I wonder of option (c)
> > makes the most sense given that 5.1 won't be viable forever:
> >
> > c) like (b) but start thinking about the future direction
> >
> 
> When 5.3 comes out we should update notion to work with that, and when
> necessary that could be a good moment to drop support for 5.1.

Fair enough.

> > Then there are of course more radical options:
> >
> > d) replace the existing build system with something more standard
> >    (autotools, or cmake)
>
> I'm not sure how those would help in this case.

You said you didn't want to add another compile time option.  With either
autotools or cmake you can make the "configure" step of the build
auto-detect which version of lua you have and whether or not you have 5.1
compat features available.

> I personally dislike autotools (esp. with all the different incompatible
> versions out there). cmake seems pretty nice, I'd really like to see if
> that could be applied to notion.

Agreed on both points.  FWIW, once upon a time, I tried to cmake-ify notion.
Sadly, I ran out of time then and then never got back to it.  Here's the
latest change I have.  Maybe you'll find it useful. :)

http://repo.or.cz/w/notion/jeffpc.git/commit/4187ec60d46d6a8a62c1abd7202a6a9bc263a7c0

Jeff.

-- 
Linux, n.:
  Generous programmers from around the world all join forces to help
  you shoot yourself in the foot for free.