Re: [Notion-devel] Patches! Some debug printing and better focuslist update behavior

[Arnout E. <ar...@bz...>]

Hi Dima,

Thanks for your patches.

1) License update: I'm still not really sure we can just replace/patch in a
new license like that. While the new license is GPG-signed, I cannot locate
the public key Tuomo used to sign the message (key id C004251B), so that's
kind of useless. OTOH it was his mailinglist and he didn't complain about
seeing an imposter, so this public record might be sufficient.

2) For debug logging, please use the ioncore/log.h instead of fprintf'ing
to stderr directly (feel free to add categories as you wish). Currently the
loglevels are hard-coded in ioncore/log.c, but that of course should be
made configurable later.

3) That sounds useful, I should look into that.


Arnout


On Tue, Jan 21, 2014 at 7:10 AM, Dima Kogan <no...@di...>wrote:

> Hi.
>
> I made a few changes, and the updated tree is the master branch at
>
>  https://github.com/dkogan/notion/
>
> This tree contains
>
> 1. The license update sent previously
>
> 2. Functions to debug-print a region hierarchy, manager hiearchy and
> focuslist contents
>
> 3. Enhanced behavior to update the focus list. After this patch windows
> are added to the focus list only after a delay. This makes it such that
> windows that were focused for a very short time are not added to the
> focus list. As a result, the user can now search for a window by quickly
> cycling through some windows. Once the user finds the window they seek,
> they can go back to the window they were previously working on using any
> key binding that consults the focus list. Prior to this patch, those
> bindings would go to the previously-focused window, even though it was
> one that was only quickly visited en route to what the user was looking
> for. After this patch, the previous window on the focus list is the one
> they were working on.
>
> This patch required the separation of the variables containing the
> "focus list" and the "currently focused region". I've been running this
> for a few days now, and things appear to work as they should.
>
>
> ------------------------------------------------------------------------------
> CenturyLink Cloud: The Leader in Enterprise Cloud Services.
> Learn Why More Businesses Are Choosing CenturyLink Cloud For
> Critical Workloads, Development Environments & Everything In Between.
> Get a Quote or Start a Free Trial Today.
>
> http://pubads.g.doubleclick.net/gampad/clk?id=119420431&iu=/4140/ostg.clktrk
> _______________________________________________
> Notion-devel mailing list
> Not...@li...
> https://lists.sourceforge.net/lists/listinfo/notion-devel
>