Re: [Notion-devel] Patches! Some debug printing and better focuslist update behavior

[Dima K. <no...@di...>]

ar...@bz... writes:

> 1) License update: I'm still not really sure we can just replace/patch in a
> new license like that. While the new license is GPG-signed, I cannot locate
> the public key Tuomo used to sign the message (key id C004251B), so that's
> kind of useless. OTOH it was his mailinglist and he didn't complain about
> seeing an imposter, so this public record might be sufficient.

I'm pretty sure it's fine. In any case, you can cherry-pick the patches
you like and skip the ones you don't. I'll keep rebasing my tree to play
nice with upstream.


> 2) For debug logging, please use the ioncore/log.h instead of fprintf'ing
> to stderr directly (feel free to add categories as you wish). Currently the
> loglevels are hard-coded in ioncore/log.c, but that of course should be
> made configurable later.

Ah yes. I didn't see that before. I updated my tree to use those. Thanks.