Re: [Notion-devel] Patches! Some debug printing and better focuslistupdate behaviorr

[Dima K. <no...@di...>]

no...@di... writes:

> I made a few changes, and the updated tree is the master branch at
>
>  https://github.com/dkogan/notion/

I found another bug, and made another patch, which now also appears in
that tree.

This is a bug in query_lua where consecutive completions would never
happen if mod_query.autoshowcompl was enabled.

To trigger the bug, invoke binding that calls

mod_query.query_lua()

Then type "ionco" and press TAB. mod_query then completes this to "ioncore.". At
this point the completion should happen again, and the various
methods/properties of ioncore should be displayed. This does not happen.
Pressing TAB again doesn't work either. One actually has to delete the "." and
re-type it.

This was happening because the second completion was being blocked. I THINK this
was trying to prevent a timer re-entrancy. However everything is synchronous, so
this couldn't happen anyway.


I've been running this for a bit, and it seems to work well. Does
somebody have more detail about why those locks were there? Is it unsafe
to remove them?

dima