From: Jeff B. <jef...@gm...> - 2013-11-03 23:37:36
|
On 11/03/2013 05:55 AM, Arnout Engelen wrote: > > Ah, sorry - with 'idem' i meant 'my previous statement also goes for > this' - in other words, I'd indeed like to apply this change to the > notion git. Great! The patches are available both in the GitHub repo as well as from DropBox: https://www.dropbox.com/sh/n1icl72l63dy9tr/guxGW9Ll8t Patches were generated on notion-3-2013030200.tar.bz2 with the latest repo version of notion-doc. You may need to play with the -p option to patch if you don't want to rebuild the whole tree. The patches are independent. They are as follows: * notion-3.2013030200.p00-man-utf8.patch - Modifies man/Makefile to run iconv after mkman.lua. Shouldn't cause Make to stop if it can't find iconv. There's probably a better way to handle this... * notion-3.2013030200.p01-fsf_addr.patch - Fixes the address for the FSF in libtu/rb.h and libtu/rb.c * notion-doc-3.2013030200.p02-css_newline.patch - rpmlint complained about doc/notion.css using <CRLF> instead of <LF>. I generated a patch for consistency and so that the build wouldn't fail if the builder doesn't have dos2unix installed. You should be able to just run dos2unix instead of installing the patch. * notion-3.2013030200.p03-ChangeLog_update.patch - Patch to replace the contents of ChangeLog with the output of gitlog-to-changelog. I only generated a changelog for the primary repo at the proper release tag. > > I don't think I use it - in any case added statusbar directory to the > script. Yeah, I generally do a 'cp */*.lua /etc/notion' but I figured I should avoid such shortcuts. :) I've added statusbar to the contrib subpackage. So I've successfully generated RPMs that pass the linter with only two outstanding issues: * No manpage for notionflux (I don't believe that this will cause much friction) * Non-binary files in /usr/lib. Not sure if this is an issue or not. I followed the file structure from the Debian notion-devel package. Any chance these can go in /usr/share/notion? o /usr/lib/notion/build/libs.mk o /usr/lib/notion/config.h o /usr/lib/notion/install-sh o /usr/lib/notion/libextl/libextl-makeports Full RPM file lists are available at the above DropBox location under RPM_File_Lists. I've verified the RPMs build and install under Fedora 18 (what I'm on), Fedora 19, and Fedora 20 (in beta). I've verified that the packages work fine under Fedora 18. Hopefully that will be sufficient. Next step is to try to make the fool thing official. Regards, Jeff -- Jeff Backus jef...@gm... http://github.com/jsbackus |