From: Arnout E. <no...@bz...> - 2013-11-02 16:27:07
|
On Fri, Nov 1, 2013 at 10:47 PM, Jeff Backus <jef...@gm...> wrote: > The RPM lint tool complains about cs/man1/notion.1.gz and > fi/man1/notion.1.gz not being UTF-8. Are there any objections to my > converting them to UTF-8 via iconv? > I wouldn't have objections to you converting them - of course ideally that change also makes it 'upstream' to our own git. > It looks like the address for the Free Software Foundation is out of > date in libtu/rb.c and libtu/rb.h. These files list the address as: > 59 Temple Place, Suite 330, Boston, MA 02111-1307 USA > however the current address is: > 51 Franklin Street, Fifth Floor, Boston, MA 02110-1301 USA > The RPM linter checks for and complains about this. I don't know if it > can be hand-waved away during the review process or not... (my first > time packaging) > Idem > contrib/statusbar isn't part of the default install? > Hmm i think it *should* be there. > There are several different licenses used in contrib/, but to me they > all appear to be compatible with GPLv3. Any objections to listing the > license as GPLv3? Fedora does allow the option of specifying multiple > licenses, but I'd like to avoid that if possible. > Not sure what Fedora's policies are on this front. For Debian we made a fairly exhaustive listing of all licenses of all different parts of the package, so you could either go for GPLv3 (if compatible) or make use of that. Up to you. > Also, a few bits of errata came up. These don't necessarily need to be > addressed but I thought I'd at least mention them. > > The ChangeLog is apparently supposed to be autogenerated, however that > does not appear to be happening. Currently, the file only contains the > statement "(The ChangeLog will be generated by release scripts from svn > logs)". Any interest in correcting this or removing it? RELNOTES appears > to be ... out of date. Any interest in correcting or removing this one > also? As it is, I'm just copying these as is, along with LICENSE and > README. > Yeah we should find a better solution there. > There does not appear to be a man page for notionflux. Any plans for > adding one in the future? Would be good to add one > Also, it appears that the documentation isn't > part of the source snapshot? At least not notion-3-2013030200-src.tar.bz2. > Makes sense to add that I suppose, yeah. Kind regards, Arnout |