Re: [Notion-devel] Some build system fixes

[Dima K. <no...@di...>]

> On Mon, 31 Dec 2012 02:43:22 -0800
> Dima Kogan <no...@di...> wrote:
>
> > On Mon, 31 Dec 2012 10:14:20 +0100
> > Arnout Engelen <no...@bz...> wrote:
> >
> > > There are similar issues in the definition of the debian package. Should those
> > > be reported directly to the debian package maintainer, or is this list a good
> > > place for those also?
> > 
> > This list is fine, me and Philipp did most of the recent packaging work.
> 
> Great.
> 
> The debianization is in the same file (system-autodetect.mk). The hardening
> flags should look something like:
> 
> 
> 
> DPKG_BUILDFLAGS_CFLAGS   := $(shell dpkg-buildflags --get CFLAGS)
> DPKG_BUILDFLAGS_CPPFLAGS := $(shell dpkg-buildflags --get CPPFLAGS)
> DPKG_BUILDFLAGS_LDFLAGS  := $(shell dpkg-buildflags --get LDFLAGS)
> 
> CFLAGS=-Os $(WARN) $(DEFINES) $(INCLUDES) $(EXTRA_INCLUDES) \
>        $(DPKG_BUILDFLAGS_CFLAGS) $(DPKG_BUILDFLAGS_CPPFLAGS)

Oops forgot a line. Should be like this:


DPKG_BUILDFLAGS_CFLAGS   := $(shell dpkg-buildflags --get CFLAGS)
DPKG_BUILDFLAGS_CPPFLAGS := $(shell dpkg-buildflags --get CPPFLAGS)
DPKG_BUILDFLAGS_LDFLAGS  := $(shell dpkg-buildflags --get LDFLAGS)

CFLAGS=-Os $(WARN) $(DEFINES) $(INCLUDES) $(EXTRA_INCLUDES) \
       $(DPKG_BUILDFLAGS_CFLAGS) $(DPKG_BUILDFLAGS_CPPFLAGS)

LDFLAGS=-Wl,--as-needed $(LIBS) $(EXTRA_LIBS) $(DPKG_BUILDFLAGS_LDFLAGS)