Re: [Notion-devel] Allowing removal of the last workspace

[Dima K. <no...@di...>]

> On Sun, 30 Dec 2012 04:00:38 -0800
> Dima Kogan <di...@se...> wrote:
>
> Hi all.
> 
> I'm observing that unlike ion3, notion allows the last workspace to be removed,
> rendering the window manager useless and requiring me to kill it to regain
> control. Normally I have keyboard commands set up to make new frames and
> workspaces, but notion is letting me kill enough of itself to prevent the keys
> from working.

To be clear, I'm killing frames with the following binding:

defbindings("WMPlex", {
    bdoc("Close current object."),
    kpress(META.."Delete", "WRegion.rqclose_propagate(_, _sub)"),
})


After killing the last visible frame, I get a black screen, but notion is still
useable and I can bring the frame back with the keyboard (although it's still
needlessly surprising to the user to be able to kill the last frame). At this
point the following have been called:

tiling_managed_disposeroot()
groupws_managed_disposeroot()
screen_managed_disposeroot()



Now if I press M-delete again, the screen remains black (no visible changes
happen), but no useable windows can be brought back. 
         
region_managed_disposeroot_default() is called during the second M-delete press.
In fact, I can keep pressing M-delete and region_managed_disposeroot_default()
keeps being called (it's a no-op). So notion isn't dead, but it's not listening
to useful input.

Hope this makes it more clear.