[Notion-devel] Some build system fixes

[Dima K. <no...@di...>]

Hi.

I started looking to fix the parts of notion that bother me. Here's the first
patch, hopefully of several.

The build system was inefficiently querying the lua installation with every
source file, even though it only was necessary once per build. This was slowing
things down dramatically, to the point where 'make -n' wasn't significantly
faster than 'make'. The attached patch makes the situation better. It's still
not once-per-build, but once-per-make-invocation. Since the build is recursive
there's a make invocation for each source directory. Non-recursive would be
better, but that would be a much more invasive change.

I also discovered some logic that looks buggy. system-autodetect.mk says this:

ifneq ($(shell which lua),)
LUA=$(LUA_DIR)/bin/lua
LUAC=$(LUA_DIR)/bin/luac
endif

Here it's looking to see if lua is available somewhere, and then if it is,
assumes that it's at $(LUA_DIR)/bin/lua and NOT wherever which said it was.
Maybe it should instead be something like

WHICH_LUA := $(shell which lua)
ifneq ($(WHICH_LUA),)
LUA=$(WHICH_LUA)
LUAC=$(WHICH_LUA)c
endif

I'm not sure what's intended here, so I can't say. Is this block necessary at
all, given that there's more logic immediately following?


There are similar issues in the definition of the debian package. Should those
be reported directly to the debian package maintainer, or is this list a good
place for those also?


Thanks
dima