Re: [Notion-devel] Flash fullscreen and mod_xinerama

[<Ten...@ya...>]

Yes, this works for me.  Thanks for tracking this down.

--Kevin

On Sun, Apr 15, 2012 at 09:29:26PM +0200, Philipp Hartwig wrote:

> Argh, the patch contained a typo. Why did that even compile? Corrected version 
> attached.

> diff --git a/ioncore/manage.c b/ioncore/manage.c
> index 9215804..3741c32 100644
> --- a/ioncore/manage.c
> +++ b/ioncore/manage.c
> @@ -151,8 +151,8 @@ static bool try_fullscreen(WClientWin *cwin, WScreen *dflt,
>          fs_scr=dflt;
>      }
>  
> -    if(fs_scr==NULL)
> -        fs_scr=netwm_check_initial_fullscreen(cwin);
> +    if(fs_scr==NULL && netwm_check_initial_fullscreen(cwin))
> +        fs_scr=dflt;
>  
>      if(fs_scr==NULL)
>          fs_scr=clientwin_fullscreen_chkrq(cwin, param->geom.w, param->geom.h);
> diff --git a/ioncore/netwm.c b/ioncore/netwm.c
> index 81db3c9..42e97dc 100644
> --- a/ioncore/netwm.c
> +++ b/ioncore/netwm.c
> @@ -107,7 +107,7 @@ void netwm_init_rootwin(WRootWin *rw)
>  /*{{{ _NET_WM_STATE */
>  
>  
> -WScreen *netwm_check_initial_fullscreen(WClientWin *cwin)
> +bool netwm_check_initial_fullscreen(WClientWin *cwin)
>  {
>  
>      int i, n;
> @@ -118,16 +118,16 @@ WScreen *netwm_check_initial_fullscreen(WClientWin *cwin)
>                     1, TRUE, (uchar**)&data);
>      
>      if(n<0)
> -        return NULL;
> +        return FALSE;
>      
>      for(i=0; i<n; i++){
>          if(data[i]==(long)atom_net_wm_state_fullscreen)
> -            return region_screen_of((WRegion*)cwin);
> +            return TRUE;
>      }
>      
>      XFree((void*)data);
>  
> -    return NULL;
> +    return FALSE;
>  }
>  
>  /*EXTL_DOC
> diff --git a/ioncore/netwm.h b/ioncore/netwm.h
> index df76886..fc054fa 100644
> --- a/ioncore/netwm.h
> +++ b/ioncore/netwm.h
> @@ -20,7 +20,7 @@
>  extern void netwm_init();
>  extern void netwm_init_rootwin(WRootWin *rw);
>  
> -extern WScreen *netwm_check_initial_fullscreen(WClientWin *cwin);
> +extern bool netwm_check_initial_fullscreen(WClientWin *cwin);
>  extern void netwm_update_state(WClientWin *cwin);
>  extern void netwm_update_allowed_actions(WClientWin *cwin);
>  extern void netwm_delete_state(WClientWin *cwin);

> ------------------------------------------------------------------------------
> For Developers, A Lot Can Happen In A Second.
> Boundary is the first to Know...and Tell You.
> Monitor Your Applications in Ultra-Fine Resolution. Try it FREE!
> http://p.sf.net/sfu/Boundary-d2dvs2

> _______________________________________________
> Notion-devel mailing list
> Not...@li...
> https://lists.sourceforge.net/lists/listinfo/notion-devel