Re: [Notion-devel] F12 on OpenIndiana (was: Re: Release)

[Josef 'J. S. <je...@jo...>]

On Thu, Oct 20, 2011 at 05:39:57PM +0200, Arnout Engelen wrote:
> On Thu, Oct 20, 2011 at 10:48:08AM -0400, Josef 'Jeff' Sipek wrote:
...
> > So, to summarize, here are my changes:
> > 
> > system.mk:
> > 	-#DEFINES += -DCF_SUN_F1X_REMAP
> > 	+DEFINES += -DCF_SUN_F1X_REMAP
> > 	-#PRELOAD_MODULES=1
> > 	+PRELOAD_MODULES=1
> > 	-#HAS_SYSTEM_ASPRINTF=1
> > 	+HAS_SYSTEM_ASPRINTF=0
> > 	-#XOPEN_SOURCE=-D__EXTENSIONS__
> > 	+XOPEN_SOURCE=-D__EXTENSIONS__
> > 	#C99_SOURCE=-std=c99 -DCF_HAS_VA_COPY
> > 	+C99_SOURCE=-xc99=%all -DCF_HAS_VA_COPY
> 
> OK, these are already documented and not compiler-specific

Right.

> > 	-PREFIX=/usr/local
> > 	+PREFIX=/usr
> 
> Is this an improvement? Shouldn't self-compiled apps go into /usr/local ?

Remember, I'm making an official package for OI. :)  I think that /usr/local
is a good default to have.

> > 	-CC=gcc
> > 	+CC=/opt/SUNWspro/sunstudio12.1/bin/cc
> > 	-WARN=  -W -Wimplicit -Wreturn-type -Wswitch -Wcomment \
> > 	-       -Wtrigraphs -Wformat -Wchar-subscripts \
> > 	-       -Wparentheses -pedantic -Wuninitialized
> > 	+WARN=
> >
> > assorted Makefiles:
> > 
> > 	* remove "-Wall"
> > 
> > libtu/Makefile:
> > 
> > 	+CFLAGS += $(XOPEN_SOURCE) $(C99_SOURCE)
> 
> These are changes needed when using Sun Studio rather than GCC, right?

Yes.

> > assorted Makefiles:
> > 
> > 	* use $(DESTDIR) to allow for installing into an arbitrary dir
> > 	  without messing up the prefix
> 
> This is a non-Solaris-specific improvement, right?

Yes, that's right.  It let's you do:

$ make install DESTDIR=$HOME/protodir

and end up with $HOME/protodir/usr/bin/notion which believes that it is in
/usr/bin/notion.  A lot of package building software uses DESTDIR.  Here's
the diff:

http://31bits.net/fix-install.patch

> > 	* add -lXinerama -lXrandr
> 
> .. and this should no longer be required
> 
> I updated https://sourceforge.net/apps/mediawiki/notion/index.php?title=Solaris#Building
> does that appear correct and complete?

Yeah, the build instructions seem fine.  The "Setting Notion as the default
window manager" is (probably) fine for Solaris 10 and older.  OpenSolaris,
OpenIndiana, and Solaris 11 use gdm & gnome by default.  As far as I know,
gdm ignores .dtprofile.  To add a gdm entry, you want to make this file:

$ cat /usr/share/xsessions/notion.desktop 
[Desktop Entry]
Encoding=UTF-8
Name=notion
Comment=This session logs you into Notion
Exec=notion
TryExec=notion
Icon=
Type=Application


As I mentioned in my previous email, I still need to get notion running with
my environment (I like my custom $PATH) - but that's not Notion related.

All in all, I'm happy with Notion :)  Is a release imminent?

Jeff.

-- 
Reality is merely an illusion, albeit a very persistent one.
		- Albert Einstein