Re: [Notion-devel] F12 on OpenIndiana (was: Re: Release)

[Arnout E. <no...@bz...>]

On Thu, Oct 20, 2011 at 10:48:08AM -0400, Josef 'Jeff' Sipek wrote:
> On Thu, Oct 20, 2011 at 02:56:09PM +0200, Arnout Engelen wrote:
> > On Wed, Oct 12, 2011 at 03:30:32PM -0400, Josef 'Jeff' Sipek wrote:
> > > There seems to be an issue with F12 not working, but I didn't add
> > > -DCF_SUN_F1X_REMAP to the right makefile.  I'll try that tonight, and
> > > hopefully I'll be able to close the session sanely :)
> > 
> > Did it help?
> 
> Yes, it did.

Great!

> I ended up packaging up xmessage since dtpad (that the wiki
> suggests using instead) is not in OI.

OK, worded the instructions a bit more neutrally

> So, to summarize, here are my changes:
> 
> system.mk:
> 	-#DEFINES += -DCF_SUN_F1X_REMAP
> 	+DEFINES += -DCF_SUN_F1X_REMAP
> 	-#PRELOAD_MODULES=1
> 	+PRELOAD_MODULES=1
> 	-#HAS_SYSTEM_ASPRINTF=1
> 	+HAS_SYSTEM_ASPRINTF=0
> 	-#XOPEN_SOURCE=-D__EXTENSIONS__
> 	+XOPEN_SOURCE=-D__EXTENSIONS__
> 	#C99_SOURCE=-std=c99 -DCF_HAS_VA_COPY
> 	+C99_SOURCE=-xc99=%all -DCF_HAS_VA_COPY

OK, these are already documented and not compiler-specific

> 	-PREFIX=/usr/local
> 	+PREFIX=/usr

Is this an improvement? Shouldn't self-compiled apps go into /usr/local ?

> 	-CC=gcc
> 	+CC=/opt/SUNWspro/sunstudio12.1/bin/cc
> 	-WARN=  -W -Wimplicit -Wreturn-type -Wswitch -Wcomment \
> 	-       -Wtrigraphs -Wformat -Wchar-subscripts \
> 	-       -Wparentheses -pedantic -Wuninitialized
> 	+WARN=
>
> assorted Makefiles:
> 
> 	* remove "-Wall"
> 
> libtu/Makefile:
> 
> 	+CFLAGS += $(XOPEN_SOURCE) $(C99_SOURCE)

These are changes needed when using Sun Studio rather than GCC, right?

> assorted Makefiles:
> 
> 	* use $(DESTDIR) to allow for installing into an arbitrary dir
> 	  without messing up the prefix

This is a non-Solaris-specific improvement, right?

> 	* add -lXinerama -lXrandr

.. and this should no longer be required

I updated https://sourceforge.net/apps/mediawiki/notion/index.php?title=Solaris#Building
does that appear correct and complete?


Kind regards,

Arnout